[BUG] Kitodo search plugin no longer works (regression)

[stweil]

Discussed in #1699

^{Originally posted by stweil August 21, 2025}
I want to install Kitodo.Presentation's main branch with TYPO3 v12 and cannot get search results from the search plugin.
A similar installation based on the 5.1.x branch with TYPO3 v11 has a working search.

Here are extracts from the Solr request logfile when a single search for "test" is done.

Good search with correct results (branch 5.1.x):

127.0.0.1 - - [21/Aug./2025:18:20:45 +0000] "GET /solr/admin/cores?wt=json&json.nl=flat&action=STATUS&core=dlfCore0 HTTP/1.0" 200 1121
127.0.0.1 - - [21/Aug./2025:18:20:45 +0000] "GET /solr/dlfCore0/select?omitHeader=true&wt=json&json.nl=flat&q=fulltext%3A%28test%29&start=0&rows=0&fl=%2A%2Cscore&facet.field=%7B%21key%3Dcollection_faceting%7Dcollection_faceting&f.collection_faceting.facet.sort=index&f.collection_faceting.facet.limit=15&f.collection_faceting.facet.mincount=1&facet=true HTTP/1.0" 200 509
127.0.0.1 - - [21/Aug./2025:18:20:45 +0000] "GET /solr/dlfCore0/select?omitHeader=true&wt=json&json.nl=flat&q=fulltext%3A%28test%29&start=0&rows=0&fl=%2A%2Cscore&facet.field=%7B%21key%3Dcollection_faceting%7Dcollection_faceting&f.collection_faceting.facet.sort=index&f.collection_faceting.facet.limit=15&f.collection_faceting.facet.mincount=1&facet=true HTTP/1.0" 200 509
127.0.0.1 - - [21/Aug./2025:18:20:46 +0000] "GET /solr/admin/cores?wt=json&json.nl=flat&action=STATUS&core=dlfCore0 HTTP/1.0" 200 1121
127.0.0.1 - - [21/Aug./2025:18:20:46 +0000] "GET /solr/dlfCore0/select?omitHeader=true&wt=json&json.nl=flat&q=fulltext%3A%28test%29&start=0&rows=0&fl=%2A%2Cscore&facet.field=%7B%21key%3Dcollection_faceting%7Dcollection_faceting&f.collection_faceting.facet.sort=index&f.collection_faceting.facet.limit=15&f.collection_faceting.facet.mincount=1&facet=true HTTP/1.0" 200 509
127.0.0.1 - - [21/Aug./2025:18:20:46 +0000] "GET /solr/dlfCore0/select?omitHeader=true&wt=json&json.nl=flat&q=fulltext%3A%28test%29&start=0&rows=0&fl=%2A%2Cscore&facet.field=%7B%21key%3Dcollection_faceting%7Dcollection_faceting&f.collection_faceting.facet.sort=index&f.collection_faceting.facet.limit=15&f.collection_faceting.facet.mincount=1&facet=true HTTP/1.0" 200 509

Bad search without any result (main branch):

127.0.0.1 - - [21/Aug./2025:18:15:40 +0000] "GET /solr/admin/cores?wt=json&json.nl=flat&action=STATUS&core=dlfCore1 HTTP/1.0" 200 1117
127.0.0.1 - - [21/Aug./2025:18:15:40 +0000] "GET /solr/dlfCore1/suggest?omitHeader=true&wt=json&json.nl=flat&suggest=true&suggest.q=test&suggest.count=10&suggest.build=false&suggest.reload=false HTTP/1.0" 200 114

If I disable search suggestions which were initially enabled for both settings, the main branch throws an exception:

 Core: Exception handler (WEB): Uncaught TYPO3 Exception: #1580585079: No valid parameter passed! | InvalidArgumentException thrown in file /var/customers/webs/weil/viewer/vendor/kitodo/presentation/Classes/Middleware/SearchSuggest.php in line 59. Requested URL: https://digital.ladenburg.world/ 

The results when I access Solr with curl show that both Solr cores (dlfCore0 for 5.1.x, dlfCore1 for main) contain fulltext with the word "test":

$ SOLR=http://localhost:8983

$ curl "$SOLR/solr/dlfCore0/select?omitHeader=true&wt=json&json.nl=flat&q=fulltext%3A%28test%29&start=0&rows=0&fl=%2A%2Cscore&facet.field=%7B%21key%3Dcollection_faceting%7Dcollection_faceting&f.collection_faceting.facet.sort=index&f.collection_faceting.facet.limit=15&f.collection_faceting.facet.mincount=1&facet=true"
{
  "response":{
    "numFound":170,
    "start":0,
    "maxScore":4.4153857,
    "numFoundExact":true,
    "docs":[ ]
  },
  "facet_counts":{
    "facet_queries":{ },
    "facet_fields":{
      "collection_faceting":["Ladenburger Tageblatt",48,"Ladenburger Wochenblatt",21,"Neckar-Bergstrass-Post",101,"ddc:070:073",170,"doc-type:Periodical",170,"doc-type:Text",170,"open_access",170,"status-type:publishedVersion",170]
    },
    "facet_ranges":{ },
    "facet_intervals":{ },
    "facet_heatmaps":{ }
  }
}

$ curl "$SOLR/solr/dlfCore1/select?omitHeader=true&wt=json&json.nl=flat&q=fulltext%3A%28test%29&start=0&rows=0&fl=%2A%2Cscore&facet.field=%7B%21key%3Dcollection_faceting%7Dcollection_faceting&f.collection_faceting.facet.sort=index&f.collection_faceting.facet.limit=15&f.collection_faceting.facet.mincount=1&facet=true"
{
  "response":{
    "numFound":21,
    "start":0,
    "maxScore":4.1382627,
    "numFoundExact":true,
    "docs":[ ]
  },
  "facet_counts":{
    "facet_queries":{ },
    "facet_fields":{
      "collection_faceting":[ ]
    },
    "facet_ranges":{ },
    "facet_intervals":{ },
    "facet_heatmaps":{ }
  }
}

[stweil]

@beatrycze-volk, according to git bisect, this regression was introduced in commit 9c5c2e7:

9c5c2e779cae3eadf618a75a0eb8ff7361c6c73e is the first bad commit
commit 9c5c2e779cae3eadf618a75a0eb8ff7361c6c73e
Author: Beatrycze Volk <beatrycze.volk@slub-dresden.de>
Date:   Mon May 19 17:53:04 2025 +0200

    [MAINTENANCE] Unify naming for search parameters (#1600)
    
    Co-authored-by: Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>

 Classes/Controller/AbstractController.php            |  2 +-
 Classes/Controller/CollectionController.php          | 20 ++++++++++----------
 Classes/Controller/ListViewController.php            | 18 +++++++++---------
 Classes/Controller/NavigationController.php          |  4 ++--
 Classes/Controller/SearchController.php              | 62 +++++++++++++++++++++++++++++++-------------------------------
 Resources/Private/Partials/ListView/SortingForm.html |  4 ++--
 Resources/Private/Partials/Lists/Pagination.html     | 10 +++++-----
 Resources/Private/Templates/Navigation/Main.html     |  2 +-
 Resources/Private/Templates/Search/Main.html         | 10 +++++-----
 9 files changed, 66 insertions(+), 66 deletions(-)

[stweil]

I could fix the Kitodo search plugin on https://digital.ladenburg.world/ by reverting this commit (see my main branch), so there currently only remains a single issue (#1551) which prevents a working installation based on Debian GNU/Linux stable (trixie), PHP 8.4 and TYPO3 v12 with the latest main branch.

[stweil]

@beatrycze-volk, I don't think that my current workaround – reverting your commit – is the best solution for this issue. Adding missing or fixing wrong parts of the commit would be better.

[beatrycze-volk]

Why reverting this commit was necessary? Did I miss one place where renaming was needed?

[stweil]

I don't know what was missing in your commit. But it breaks the search for me: I no longer get any result (and I also don't see that Kitodo tries to get results from Solr, see details above).

[stweil]

Unrelated: Search suggestions seem to be broken as well. This is now addressed in issue #1702.

[sebastian-meyer]

Summoning @frank-ulrich-weber. Maybe this is related to your changes in #454?

[sebastian-meyer]

So, according to #1701 there is no bug in Kitodo.Presentation and searching works as long as you don't use slub/dfg-viewer, right?