-
Notifications
You must be signed in to change notification settings - Fork 45
Open
Labels
☇ bugA non-security related bug.A non-security related bug.
Milestone
Description
Description
The viewer no longer works with newspapers in an installation of latest Kitodo.Presentation with latest dfgviewer and slub-digitalcollections.
TYPO3 shows runtime exceptions. In addition, essential functionality is missing in the document viewer.
- Runtime exception because of missing PHP dependency (fix: [BUGFIX] Add required typo3/cms-reports #1767)
- Runtime exception because of missing type cast (possible fix: [BUGFIX] Add missing type cast #1765)
- Fulltext button and fulltext missing in viewer. Works again in test with code from 2025-12-08.
- Missing dc:calc in dfgviewer, see slub_digitalcollections. Fixed in [BUGFIX] Remove usage of
CalcViewHelperslub/dfg-viewer#383. - Runtime exception because of typed static property, see slub_digitalcollections. Fixed in [BUGFIX] Fix static call to
$documentRepositoryslub/slub_digitalcollections#195.
Reproduction
Install it and try to display a newspaper (years, months, individual issue).
Expected Behavior
No regression.
Environment
- OS version: Debian GNU Linux stable
- TYPO3 version: 12
Additional Context
See my comments for the pull requests slub/slub_digitalcollections#179 and slub/slub_digitalcollections#186 which are responsible for two regressions.
One more regressions remains after reverting these two commits:
Tue, 25 Nov 2025 14:23:47 +0100 [ALERT] request="806b92604d22b" component="TYPO3.CMS.Frontend.ContentObject.Exception.ProductionExceptionHandler":
Oops, an error occurred! Code: 202511251423476245d421- Exception:
Kitodo\Dlf\ViewHelpers\LinkViewHelper::doubleEncode(): Argument #1 ($url) must be of type string, int given,
called in /viewer/vendor/kitodo/presentation/Classes/ViewHelpers/LinkViewHelper.php on line 75
[...]
Metadata
Metadata
Assignees
Labels
☇ bugA non-security related bug.A non-security related bug.