Delete old methods

Author: BartChris

Kitodo-DataManagement/src/main/java/org/kitodo/data/database/beans/Process.java

@@ -783,77 +783,6 @@ public void setOcrdWorkflowId(String ocrdWorkflowId) {
         this.ocrdWorkflowId = ocrdWorkflowId;
     }
 
-    /**
-     * Returns the percentage of tasks in the process that are completed. The
-     * total of tasks awaiting preconditions, startable, in progress, and
-     * completed is {@code 100.0d}.
-     *
-     * @return percentage of tasks completed
-     */
-    public Double getProgressClosed() {
-        if (CollectionUtils.isEmpty(tasks) && !hasChildren()) {
-            return 0.0;
-        }
-        return getTaskProgress(MAX_AGE_NANOSS).get(TaskStatus.DONE);
-    }
-
-    /**
-     * Returns the percentage of tasks in the process that are currently being
-     * processed. The progress total of tasks waiting for preconditions,
-     * startable, in progress, and completed is {@code 100.0d}.
-     *
-     * @return percentage of tasks in progress
-     */
-    public Double getProgressInProcessing() {
-        if (CollectionUtils.isEmpty(tasks) && !hasChildren()) {
-            return 0.0;
-        }
-        return getTaskProgress(MAX_AGE_NANOSS).get(TaskStatus.INWORK);
-    }
-
-    /**
-     * Returns the percentage of the process's tasks that are now ready to be
-     * processed but have not yet been started. The progress total of tasks
-     * waiting for preconditions, startable, in progress, and completed is
-     * {@code 100.0d}.
-     *
-     * @return percentage of startable tasks
-     */
-    public Double getProgressOpen() {
-        if (CollectionUtils.isEmpty(tasks) && !hasChildren()) {
-            return 0.0;
-        }
-        return getTaskProgress(MAX_AGE_NANOSS).get(TaskStatus.OPEN);
-    }
-
-    private Map<TaskStatus, Double> getTaskProgress(long maxAgeNanos) {
-        long now = System.nanoTime();
-        if (Objects.isNull(this.taskProgress) || now - taskProgress.getLeft() > maxAgeNanos) {
-            Map<TaskStatus, Double> taskProgress = ProcessConverter.getTaskProgressPercentageOfProcess(this, true);
-            this.taskProgress = Pair.of(System.nanoTime(), taskProgress);
-        } else {
-            this.taskProgress = Pair.of(now, taskProgress.getValue());
-        }
-        Map<TaskStatus, Double> value = taskProgress.getValue();
-        return value;
-    }
-
-    /**
-     * Returns a coded overview of the progress of the process. The larger the
-     * number, the more advanced the process is, so it can be used to sort by
-     * progress. The numeric code consists of twelve digits, each three digits
-     * from 000 to 100 indicate the percentage of tasks completed, currently in
-     * progress, ready to start and not yet ready, in that order. For example,
-     * 000000025075 means that 25% of the tasks are ready to be started and 75%
-     * of the tasks are not yet ready to be started because previous tasks have
-     * not yet been processed.
-     * 
-     * @return overview of the processing status
-     */
-    public String getProgressCombined() {
-        return ProcessConverter.getCombinedProgressFromTaskPercentages(getTaskProgress(MAX_AGE_NANOSS));
-    }
-
     /**
      * Returns the record number of the parent process, if any. Is {@code 0} if
      * there is no parent process above.

Kitodo/src/main/java/org/kitodo/production/forms/ProcessForm.java

@@ -105,8 +105,6 @@ public class ProcessForm extends TemplateBaseForm {
     private final Map<Integer, Boolean> assignedProcesses = new HashMap<>();
     private String settingImportConfigurationResultMessage;
     private boolean importConfigurationsSetSuccessfully = false;
-    private boolean initialized = false;
-
 
     @Inject
     private CustomListColumnInitializer initializer;

Kitodo/src/main/java/org/kitodo/production/forms/ProcessListBaseView.java

@@ -277,9 +277,9 @@ public Map<TaskStatus, Integer> getCachedTaskStatusCounts(Process process) {
     public double progress(Process process, TaskStatus status) {
         Map<TaskStatus, Integer> counts = getCachedTaskStatusCounts(process);
         int total = counts.values().stream().mapToInt(Integer::intValue).sum();
-        // keep legacy semantics
         if (total == 0) {
-            return status == TaskStatus.LOCKED ? 100.0 : 0.0;
+            counts.put(TaskStatus.LOCKED, 1);
+            total = 1;
         }
         return 100.0 * counts.getOrDefault(status, 0) / total;
     }