Add getJenkinsBuild helper and use it for builds

Work around broken base URL by constructing Build.Base and polling it.
Replace direct job.GetBuild calls with getJenkinsBuild and add error
handling. Add errors and strconv imports.

Author: alexec

duration.go

@@ -6,30 +6,30 @@ import "fmt"
 // Returns the largest unit that makes sense: N days, N hours, N minutes, or N seconds
 func formatDuration(milliseconds float64) string {
 	seconds := int64(milliseconds / 1000)
-	
+
 	if seconds < 60 {
 		if seconds == 1 {
 			return "1 second"
 		}
 		return fmt.Sprintf("%d seconds", seconds)
 	}
-	
+
 	minutes := seconds / 60
 	if minutes < 60 {
 		if minutes == 1 {
 			return "1 minute"
 		}
 		return fmt.Sprintf("%d minutes", minutes)
 	}
-	
+
 	hours := minutes / 60
 	if hours < 24 {
 		if hours == 1 {
 			return "1 hour"
 		}
 		return fmt.Sprintf("%d hours", hours)
 	}
-	
+
 	days := hours / 24
 	if days == 1 {
 		return "1 day"

duration_test.go

@@ -16,19 +16,19 @@ func TestFormatDuration(t *testing.T) {
 		{5000, "5 seconds"},
 		{30000, "30 seconds"},
 		{59000, "59 seconds"},
-		
+
 		// Minutes
 		{60000, "1 minute"},
 		{120000, "2 minutes"},
 		{1800000, "30 minutes"},
 		{3599000, "59 minutes"},
-		
+
 		// Hours
 		{3600000, "1 hour"},
 		{7200000, "2 hours"},
 		{43200000, "12 hours"},
 		{86399000, "23 hours"},
-		
+
 		// Days
 		{86400000, "1 day"},
 		{172800000, "2 days"},

main.go

@@ -2,10 +2,12 @@ package main
 
 import (
 	"context"
+	"errors"
 	"flag"
 	"fmt"
 	"os"
 	"os/signal"
+	"strconv"
 	"strings"
 	"syscall"
 
@@ -265,19 +267,31 @@ func getJob(ctx context.Context, jobName string) error {
 	return nil
 }
 
+func getJenkinsBuild(ctx context.Context, jobName string, job *gojenkins.Job, id int64) (*gojenkins.Build, error) {
+	jobURL := "/job/" + jobName // hack for broken base URL
+	build := gojenkins.Build{Jenkins: job.Jenkins, Job: job, Raw: new(gojenkins.BuildResponse), Depth: 1, Base: jobURL + "/" + strconv.FormatInt(id, 10)}
+	status, err := build.Poll(ctx)
+	if err != nil {
+		return nil, err
+	}
+	if status == 200 {
+		return &build, nil
+	}
+	return nil, errors.New(strconv.Itoa(status))
+}
+
 // getBuild gets details of a specific build
 func getBuild(ctx context.Context, jobName, buildNumber string) error {
 	job, err := jenkins.GetJob(ctx, jobName)
 	if err != nil {
 		return fmt.Errorf("failed to get job: %w", err)
 	}
-
 	buildNum, err := parseBuildNumber(buildNumber)
 	if err != nil {
 		return err
 	}
 
-	build, err := job.GetBuild(ctx, buildNum)
+	build, err := getJenkinsBuild(ctx, jobName, job, buildNum)
 	if err != nil {
 		return fmt.Errorf("failed to get build: %w", err)
 	}
@@ -298,7 +312,7 @@ func getBuildLog(ctx context.Context, jobName, buildNumber string) error {
 		return err
 	}
 
-	build, err := job.GetBuild(ctx, buildNum)
+	build, err := getJenkinsBuild(ctx, jobName, job, buildNum)
 	if err != nil {
 		return fmt.Errorf("failed to get build: %w", err)
 	}