Skip to content

Commit fb7ebd2

Browse files
committed
Fix trailing empty packets getting dropped
1 parent 3a5c9f0 commit fb7ebd2

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/App/Osu/Bancho.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,6 @@ void BanchoState::handle_packet(Packet &packet) {
479479
}
480480

481481
case MATCH_ALL_PLAYERS_LOADED: {
482-
debugLog("MATCH_ALL_PLAYERS_LOADED");
483482
osu->getMapInterface()->all_players_loaded = true;
484483
osu->getChat()->updateVisibility();
485484
break;

src/App/Osu/BanchoNetworking.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ void parse_packets(u8 *data, size_t s_data) {
4848
};
4949

5050
// + 7 for packet header
51-
while(batch.pos + 7 < batch.size) {
51+
while(batch.pos + 7 <= batch.size) {
5252
u16 packet_id = batch.read<u16>();
5353
batch.pos++; // skip compression flag
5454
u32 packet_len = batch.read<u32>();
@@ -338,7 +338,7 @@ void BanchoState::disconnect() {
338338
NetworkHandler::Response response = networkHandler->httpRequestSynchronous(query_url, options);
339339

340340
free(packet.memory);
341-
} else if (BanchoState::is_logging_in()) {
341+
} else if(BanchoState::is_logging_in()) {
342342
// HACKHACK: can't cancel existing in-progress request directly
343343
BanchoState::async_logout_pending = true;
344344
}

0 commit comments

Comments
 (0)