fix Downloader

Author: ewilan-riviere

src/Utils/Downloader/Downloader.php

@@ -10,6 +10,8 @@
  */
 class Downloader
 {
+    protected int $chunkSize = 8192;
+
     protected function __construct(
         protected ?string $filename = null,
         protected ?int $size = null,
@@ -70,6 +72,12 @@ public function mimeType(?string $mimeType = null): static
         return $this;
     }
 
+    public function chunkSize(int $bytes): static
+    {
+        $this->chunkSize = max(1024, $bytes);
+        return $this;
+    }
+
     /**
      * Send headers for the download.
      */
@@ -80,7 +88,12 @@ protected function sendHeaders(): void
         }
         header("Content-Type: {$this->mimeType}");
         header('Content-Description: file transfer');
-        header("Content-Disposition: attachment;filename={$this->filename}");
+
+        $filename = $this->filename;
+        $encoded = rawurlencode($filename);
+
+        header("Content-Disposition: attachment; filename=\"{$encoded}\"; filename*=UTF-8''{$encoded}");
+
 
         if ($this->size) {
             header("Content-Length: {$this->size}");
@@ -90,6 +103,26 @@ protected function sendHeaders(): void
         header('Expires: -1');
         header('Cache-Control: no-cache');
         header('Cache-Control: public, must-revalidate, post-check=0, pre-check=0');
+
+        if (function_exists('apache_setenv')) {
+            apache_setenv('no-gzip', '1');
+        }
+        ini_set('zlib.output_compression', 'Off');
+    }
+
+    protected function flushOutput(): void
+    {
+        if (ob_get_level() > 0) {
+            @ob_flush();
+        }
+        flush();
+    }
+
+    protected function clearOutputBuffers(): void
+    {
+        while (ob_get_level() > 0) {
+            ob_end_clean();
+        }
     }
 
     /**

src/Utils/Downloader/DownloaderDirect.php

@@ -31,7 +31,10 @@ public function name(string $name): static
      */
     public function autoMimeType(): self
     {
-        $this->mimeType = mime_content_type($this->path);
+        $mime = mime_content_type($this->path);
+        if ($mime !== false) {
+            $this->mimeType = $mime;
+        }
 
         return $this;
     }
@@ -58,13 +61,22 @@ public function get(): void
         }
         ini_set('max_execution_time', $this->maxExecutionTime);
 
+        $this->clearOutputBuffers();
         $this->sendHeaders();
         $file = fopen($this->path, 'rb');
+        if ($file === false) {
+            throw new \RuntimeException("Unable to open file: {$this->path}");
+        }
+
+        while (!feof($file)) {
+            $chunk = fread($file, $this->chunkSize);
+            if ($chunk === false) {
+                break;
+            }
+
+            echo $chunk;
+            $this->flushOutput();
 
-        while (! feof($file)) {
-            echo fread($file, 1024 * 8);
-            ob_flush();
-            flush();
             if ($this->speed) {
                 usleep($this->speed);
             }

src/Utils/Downloader/DownloaderZipStream.php

@@ -39,6 +39,7 @@ public function get(): void
             throw new \Exception('`maennchen/zipstream-php` is not installed. Install it from GitHub https://github.com/maennchen/ZipStream-PHP');
         }
 
+        $this->clearOutputBuffers();
         $this->sendHeaders();
         $zip = new \ZipStream\ZipStream(
             outputName: str_replace(' ', '.', $this->filename),