Fix bug when field doesn't have a value yet and it tries to join (#36)

Author: chrisrohr

Diff for: lib/components/DynamicPropertyField.vue

@@ -231,9 +231,9 @@ const singleListDisplay = (fieldValue: string | number): string => {
     return props.field.values.filter(
       (v: { value: string | number }) => v.value === fieldValue,
     )[0].display;
-  } else {
-    return "";
   }
+
+  return "";
 };
 
 const multipleListDisplay = (fieldValue: Array<string | number>): string => {
@@ -246,8 +246,8 @@ const multipleListDisplay = (fieldValue: Array<string | number>): string => {
           )[0].display,
       )
       .join(", ");
-  } else {
-    return "";
   }
+
+  return "";
 };
 </script>

Diff for: lib/components/DynamicPropertyTable.vue

@@ -78,17 +78,21 @@ function resolveAndJoinValues(
   field: { values: Array<{ value: string | number; display: string }> },
   fieldValue: string | number | Array<string | number>,
 ): string {
-  if (Array.isArray(fieldValue)) {
-    return fieldValue
-      .map(
-        (fv: string | number) =>
-          field.values.filter(
-            (f: { value: string | number }) => f.value === fv,
-          )[0].display,
-      )
-      .join(", ");
+  if (fieldValue) {
+    if (Array.isArray(fieldValue)) {
+      return fieldValue
+        .map(
+          (fv: string | number) =>
+            field.values.filter(
+              (f: { value: string | number }) => f.value === fv,
+            )[0].display,
+        )
+        .join(", ");
+    }
+
+    return field.values.filter((f) => f.value === fieldValue)[0].display;
   }
 
-  return field.values.filter((f) => f.value === fieldValue)[0].display;
+  return "";
 }
 </script>

Diff for: package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@kiwiproject/vue-dynamic-property-provider",
-  "version": "0.9.0",
+  "version": "0.9.1",
   "private": false,
   "type": "module",
   "files": [