STNDP-144 Handle todo comments and miscellaneous bugs - cleanup (#92)

* STNDP-144 Handle todo comments and miscellaneous bugs - cleanup

Author: hyokualexkwon

apps/api/drizzle-dev.config.ts

@@ -2,8 +2,10 @@ import { defineConfig } from 'drizzle-kit';
 import * as dotenv from 'dotenv';
 import path from 'path';
 
-// TODO: Seems like this is not working. It always uses the .env file. Make it work.
-dotenv.config({ path: path.join(__dirname, '.env.development.local') });
+dotenv.config({
+  path: path.join(__dirname, '.env.development.local'),
+  override: true,
+});
 
 export default defineConfig({
   out: './src/libs/db/migrations',

apps/api/src/app.controller.ts

@@ -1,4 +1,4 @@
-import { Controller, Get } from '@nestjs/common';
+import { Controller, Get, InternalServerErrorException } from '@nestjs/common';
 import { AppService } from './app.service';
 
 @Controller()
@@ -7,6 +7,11 @@ export class AppController {
 
   @Get()
   getHello(): string {
-    return this.appService.getHello();
+    try {
+      return this.appService.getHello();
+    } catch (error) {
+      console.error(error);
+      throw new InternalServerErrorException();
+    }
   }
 }

apps/api/src/auth/auth-service.types.ts

@@ -38,7 +38,7 @@ export interface User {
   display_name: string | null;
   selected_team: Team | null;
   selected_team_id: string | null;
-  profile_image_url: string;
+  profile_image_url: string | null;
   client_metadata: Record<string, any> | null;
   client_read_only_metadata: ClientReadOnlyMetadata | null;
   server_metadata: Record<string, any> | null;

apps/api/src/auth/token/token.controller.ts

@@ -1,13 +1,23 @@
-import { Controller, Post, UseGuards } from '@nestjs/common';
+import {
+  Controller,
+  Post,
+  UseGuards,
+  InternalServerErrorException,
+} from '@nestjs/common';
 import { AuthGuard } from '../guards/auth.guard';
 
 @Controller('auth/token')
 export class TokenController {
   @UseGuards(AuthGuard)
   @Post('verify')
   async verifyToken() {
-    return {
-      valid: true,
-    };
+    try {
+      return {
+        valid: true,
+      };
+    } catch (error) {
+      console.error(error);
+      throw new InternalServerErrorException();
+    }
   }
 }

apps/api/src/auth/users/users.controller.ts

@@ -19,17 +19,26 @@ export class UsersController {
 
   @UseGuards(AuthGuard)
   @Get('me')
-  getMe(@Req() request: AuthenticatedRequest) {
-    const userId = request.userId;
-    return this.usersService.get(userId);
+  async getMe(@Req() request: AuthenticatedRequest) {
+    try {
+      const userId = request.userId;
+      return await this.usersService.get(userId);
+    } catch (error) {
+      console.error(error);
+      throw new InternalServerErrorException();
+    }
   }
 
   @UseGuards(AuthGuard)
   @Get('me/boards')
-  getMyBoards(@Req() request: AuthenticatedRequest): Promise<Board[]> {
-    const userId = request.userId;
-    // TODO: handle error case
-    return this.usersService.getBoardsOfUser(userId);
+  async getMyBoards(@Req() request: AuthenticatedRequest): Promise<Board[]> {
+    try {
+      const userId = request.userId;
+      return await this.usersService.getBoardsOfUser(userId);
+    } catch (error) {
+      console.error(error);
+      throw new InternalServerErrorException();
+    }
   }
 
   @UseGuards(AuthGuard)

apps/api/src/auth/users/users.service.ts

@@ -78,12 +78,23 @@ export class UsersService {
         },
       },
     );
-    const user: User = await response.json(); // TODO: handle error case
+
+    if (!response.ok) {
+      throw new Error(
+        `Failed to fetch user: ${response.status} ${response.statusText}`,
+      );
+    }
+
+    const data: User | { error: string; code: string } = await response.json();
+
+    if ('error' in data) {
+      throw new Error(data.error);
+    }
 
     // NOTE: This is to avoid the server_metadata property from being included in the response
-    user.server_metadata = null;
+    data.server_metadata = null;
 
-    return user;
+    return data;
   }
 
   async list(params?: {
@@ -158,9 +169,19 @@ export class UsersService {
       },
     );
 
-    const updatedUser: User = await response.json(); // TODO: handle error case
+    if (!response.ok) {
+      throw new Error(
+        `Failed to update user: ${response.status} ${response.statusText}`,
+      );
+    }
+
+    const data: User | { error: string; code: string } = await response.json();
+
+    if ('error' in data) {
+      throw new Error(data.error);
+    }
 
-    return updatedUser;
+    return data;
   }
 
   async updateClientReadOnlyMetadata(

apps/api/src/libs/db/schema.ts

@@ -8,8 +8,8 @@ import {
   serial,
   primaryKey,
   jsonb,
-  AnyPgColumn,
   pgEnum,
+  type AnyPgColumn,
 } from 'drizzle-orm/pg-core';
 
 // TODO: add owner role

apps/api/src/types/index.ts

@@ -0,0 +1,27 @@
+// Database types from Drizzle schema
+export type {
+  Board,
+  InsertBoard,
+  StandupForm,
+  InsertStandupForm,
+  Standup,
+  InsertStandup,
+  UsersToBoards,
+  InsertUsersToBoards,
+  Invitation,
+  InsertInvitation,
+  UsersToBoardsRole,
+} from '../libs/db/schema';
+
+// Auth service types
+export type {
+  User,
+  ListUser,
+  Team,
+  ClientReadOnlyMetadata,
+  ViewType,
+  OtpSignInResponse,
+} from '../auth/auth-service.types';
+
+// Add other domain types here as the project grows
+// export type { SomeType } from '../other/module';

apps/web/app/hooks/use-key-press.ts

@@ -0,0 +1,126 @@
+import { useEffect, useRef } from "react";
+
+// Credit: Based on https://github.com/uidotdev/usehooks/blob/experimental/index.js
+// Enhanced for keyboard shortcuts with key combinations and input field detection
+
+interface UseKeyPressOptions {
+  event?: "keydown" | "keyup";
+  target?: Window | Document | HTMLElement;
+  eventOptions?: boolean | AddEventListenerOptions;
+}
+
+// Helper function to parse key combinations like "Meta+Enter" or "Control+Enter"
+function parseKeySpec(keySpec: string): {
+  key: string;
+  ctrlKey?: boolean;
+  metaKey?: boolean;
+  shiftKey?: boolean;
+  altKey?: boolean;
+} {
+  const parts = keySpec.split("+");
+  const result: {
+    key: string;
+    ctrlKey?: boolean;
+    metaKey?: boolean;
+    shiftKey?: boolean;
+    altKey?: boolean;
+  } = {
+    key: "", // Will be set when we find the actual key
+  };
+
+  for (const part of parts) {
+    const normalizedPart = part.toLowerCase();
+
+    switch (normalizedPart) {
+      case "ctrl":
+      case "control":
+        result.ctrlKey = true;
+        break;
+      case "meta":
+      case "cmd":
+      case "command":
+        result.metaKey = true;
+        break;
+      case "shift":
+        result.shiftKey = true;
+        break;
+      case "alt":
+      case "option":
+        result.altKey = true;
+        break;
+      default:
+        result.key = part; // Keep original case for the actual key
+    }
+  }
+
+  return result;
+}
+
+// Helper function to check if event matches the key specification
+function matchesKeySpec(event: KeyboardEvent, keySpec: string): boolean {
+  const spec = parseKeySpec(keySpec);
+
+  // Check the main key
+  if (spec.key && event.key !== spec.key) {
+    return false;
+  }
+
+  // Ensure modifiers match exactly. If not in spec, they must be false.
+  if (event.ctrlKey !== (spec.ctrlKey ?? false)) {
+    return false;
+  }
+  if (event.metaKey !== (spec.metaKey ?? false)) {
+    return false;
+  }
+  if (event.shiftKey !== (spec.shiftKey ?? false)) {
+    return false;
+  }
+  if (event.altKey !== (spec.altKey ?? false)) {
+    return false;
+  }
+
+  return true;
+}
+
+export function useKeyPress(
+  key: string | string[],
+  callback: (event: KeyboardEvent) => void,
+  options: UseKeyPressOptions = {}
+) {
+  const {
+    event = "keydown",
+    target = typeof window !== "undefined" ? window : null,
+    eventOptions,
+  } = options;
+
+  const callbackRef = useRef(callback);
+
+  // Keep callback ref up to date
+  useEffect(() => {
+    callbackRef.current = callback;
+  });
+
+  useEffect(() => {
+    if (!target) return;
+
+    const handler = (evt: Event) => {
+      const event = evt as KeyboardEvent;
+      const keys = Array.isArray(key) ? key : [key];
+
+      // Check if any of the specified keys match
+      for (const keySpec of keys) {
+        if (matchesKeySpec(event, keySpec)) {
+          callbackRef.current(event);
+          break;
+        }
+      }
+    };
+
+    const targetElement = target as EventTarget;
+    targetElement.addEventListener(event, handler, eventOptions);
+
+    return () => {
+      targetElement.removeEventListener(event, handler, eventOptions);
+    };
+  }, [key, target, event, eventOptions]);
+}

apps/web/app/radix.css

@@ -14,4 +14,6 @@
   --default-font-family: "Inter", -apple-system, BlinkMacSystemFont,
     "Segoe UI (Custom)", Roboto, "Helvetica Neue", "Open Sans (Custom)",
     system-ui, sans-serif, "Apple Color Emoji", "Segoe UI Emoji";
+
+  --color-background: var(--accent-1);
 }