Skip to content

Commit 0c4c3ef

Browse files
committed
fix(ci): remove impossible dependencies from docker job
The docker job runs on push events to master/develop branches, but it was depending on docker-test and dependency-review jobs which only run on pull_request events. This created an impossible dependency chain that prevented the docker job from ever running. This change: - Removes docker-test and dependency-review from docker job dependencies - Keeps only the test job as a dependency (which runs on both events) - Allows docker build & push to run correctly on push events - Maintains PR-specific checks (docker-test, dependency-review) for PRs
1 parent 2d995fb commit 0c4c3ef

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ jobs:
354354
permissions:
355355
contents: read
356356
packages: write
357-
needs: [test, docker-test, dependency-review]
357+
needs: [test]
358358
if: |
359359
github.event_name == 'push' && (github.ref == 'refs/heads/master' ||
360360
github.ref == 'refs/heads/develop' ||

0 commit comments

Comments
 (0)