You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've addressed the concern about the Docker container running as root while the README claims non-root execution. The implementation includes:
4
+
5
+
1. Added a non-root user (appuser with UID 1000) in the builder stage
6
+
2. Copy the passwd file to the scratch image to make the USER directive work
7
+
3. Added USER directive to run the container as the non-root user
8
+
4. Created Dockerfile.dev for development with shell access (using Alpine instead of scratch)
9
+
5. Fixed docker-compose.yml to use proper YAML anchors
10
+
11
+
This change ensures that the Docker container actually runs as a non-privileged user as stated in the README, which is an important security best practice.
12
+
13
+
## Other PR Comments
14
+
15
+
Regarding the other PR comments:
16
+
17
+
1. For prerelease flag in release.yml:
18
+
- The suggested change to add a comment explaining the rationale for using 'startsWith(github.ref, \"refs/tags/v0.\")' is good practice
19
+
- v0.x.x versions follow semver convention for pre-1.0 software that may have breaking changes
20
+
21
+
2. For dependency-review.yml and codeql.yml workflow trigger changes:
22
+
- Switching from 'pull_request' to 'workflow_call' changes how these workflows are triggered
23
+
- Documentation should be added to explain when and how these workflows should be called
24
+
- This may impact security scanning, so careful consideration is needed
0 commit comments