Fix Ruby "method refined" warning (#433)

mattbrictson · web-flow · commit cfcffd118e03 · 2024-11-05T02:18:08.000+01:00
When Ruby warnings are enabled, this is printed when loading the
sitemap_generator gem:

&gt; sitemap_generator-6.3.0/lib/sitemap_generator/templates.rb:16):1: warning: method redefined; discarding old sitemap_sample

This is because an attr reader (e.g. `sitemap_sample`) was being defined
via `attr_accessor` and then immediately redefined with `define_method`.

Fix by using `attr_writer` instead of `attr_accessor`, so that the attr
reader is not defined twice.
diff --git a/lib/sitemap_generator/templates.rb b/lib/sitemap_generator/templates.rb
@@ -13,7 +13,7 @@ class Templates
     }
 
     # Dynamically define accessors for each key defined in <tt>FILES</tt>
-    attr_accessor(*FILES.keys)
+    attr_writer(*FILES.keys)
 
     FILES.each_key do |name|
       eval(<<-ACCESSOR, binding, __FILE__ , __LINE__ + 1)

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ class Templates`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`# Dynamically define accessors for each key defined in <tt>FILES</tt>`
`16`		`- attr_accessor(*FILES.keys)`
	`16`	`+ attr_writer(*FILES.keys)`
`17`	`17`
`18`	`18`	`FILES.each_key do \|name\|`
`19`	`19`	`eval(<<-ACCESSOR, binding, __FILE__ , __LINE__ + 1)`