Updating Error Source Pointer Logic (#244)

* updating error pointer logic

* fix test

Author: dan-peluso

sdk/analytics/src/main/java/com/klaviyo/analytics/networking/requests/KlaviyoErrorResponse.kt

@@ -33,7 +33,7 @@ data class KlaviyoErrorSource(
 ) {
     internal companion object {
         // current path objects from the backend
-        const val EMAIL_PATH = "/data/attributes/email"
-        const val PHONE_NUMBER_PATH = "/data/attributes/phone_number"
+        const val EMAIL_PATH = "attributes/email"
+        const val PHONE_NUMBER_PATH = "attributes/phone_number"
     }
 }

sdk/analytics/src/main/java/com/klaviyo/analytics/state/StateSideEffects.kt

@@ -117,16 +117,17 @@ internal class StateSideEffects(
         request.responseCode == HTTP_BAD_REQUEST -> {
             request.errorBody.errors.find { it.title == KlaviyoErrorResponse.INVALID_INPUT_TITLE }
                 ?.let { inputError ->
-                    when (inputError.source?.pointer) {
-                        KlaviyoErrorSource.EMAIL_PATH -> {
+                    val pointer = inputError.source?.pointer
+                    when {
+                        pointer?.contains(KlaviyoErrorSource.EMAIL_PATH) == true -> {
                             (Registry.get<State>() as? KlaviyoState)?.resetEmail().also {
                                 Registry.log.warning(
                                     "Invalid email - resetting email state to null"
                                 )
                             }
                         }
 
-                        KlaviyoErrorSource.PHONE_NUMBER_PATH -> {
+                        pointer?.contains(KlaviyoErrorSource.PHONE_NUMBER_PATH) == true -> {
                             (Registry.get<State>() as? KlaviyoState)?.resetPhoneNumber().also {
                                 Registry.log.warning(
                                     "Invalid phone number - resetting phone number state to null"

sdk/analytics/src/test/java/com/klaviyo/analytics/state/StateSideEffectsTest.kt

@@ -340,4 +340,68 @@ class StateSideEffectsTest : BaseTest() {
 
         assertFalse(capturedPushState.isCaptured)
     }
+
+    @Test
+    fun `updated phone error source pointer still resets state`() {
+        Registry.register<State>(klaviyoStateMock)
+        StateSideEffects(
+            state = klaviyoStateMock,
+            apiClient = apiClientMock
+        )
+
+        capturedApiObserver.captured(
+            mockk<ProfileApiRequest>().apply {
+                every { status } returns KlaviyoApiRequest.Status.Failed
+                every { responseCode } returns 400
+                every { errorBody } returns KlaviyoErrorResponse(
+                    listOf(
+                        KlaviyoError(
+                            id = "67ed6dbf-1653-499b-a11d-30310aa01ff7",
+                            status = 400,
+                            title = "Invalid input.",
+                            detail = "Invalid phone number format (Example of a valid format: +12345678901)",
+                            source = KlaviyoErrorSource(
+                                pointer = "/data/attributes/profile/data/attributes/phone_number"
+                            )
+                        )
+                    )
+                )
+            }
+        )
+
+        verify { klaviyoStateMock.resetPhoneNumber() }
+        Registry.unregister<State>()
+    }
+
+    @Test
+    fun `updated email error source pointer still resets state`() {
+        Registry.register<State>(klaviyoStateMock)
+        StateSideEffects(
+            state = klaviyoStateMock,
+            apiClient = apiClientMock
+        )
+
+        capturedApiObserver.captured(
+            mockk<ProfileApiRequest>().apply {
+                every { status } returns KlaviyoApiRequest.Status.Failed
+                every { responseCode } returns 400
+                every { errorBody } returns KlaviyoErrorResponse(
+                    listOf(
+                        KlaviyoError(
+                            id = "67ed6dbf-1653-499b-a11d-30310aa01ff7",
+                            status = 400,
+                            title = "Invalid input.",
+                            detail = "This email is complete chicanery",
+                            source = KlaviyoErrorSource(
+                                pointer = "/data/attributes/profile/data/attributes/email"
+                            )
+                        )
+                    )
+                )
+            }
+        )
+
+        verify { klaviyoStateMock.resetEmail() }
+        Registry.unregister<State>()
+    }
 }