address review feedback

Author: n4t4l

cmd/operator/multisign.go

@@ -3,7 +3,9 @@ package main
 import (
 	"encoding/hex"
 	"encoding/json"
+	"errors"
 	"fmt"
+	"io"
 	"strings"
 
 	"github.com/klever-io/klever-go/cmd/operator/utils"
@@ -153,7 +155,9 @@ func subMS() []*cobra.Command {
 		Use:   "sign [txHash]",
 		Short: "sign a transaction from multisign API and post the signature",
 		Example: `operator ms sign <txHash>   — sign specific TX by hash
-operator ms sign            — interactively choose from pending transactions`,
+operator ms sign <txHash> -s — sign specific TX by hash; skip confirmation prompt 
+operator ms sign             — interactively choose from pending transactions
+operator ms sign -s          — interactively choose from pending transactions; skip confirmation prompt`,
 		Args: cobra.MaximumNArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			log.Info("signing transaction from multisign API", "address", signerAddress)
@@ -165,7 +169,7 @@ operator ms sign            — interactively choose from pending transactions`,
 				log.Info("fetching pending transactions for signing")
 				result := make([]MSApiTransaction, 0)
 				err = utils.GetURL(fmt.Sprintf("%s/transaction/by-address/%s", multisignAPI, signerAddress), &result)
-				if err != nil && err.Error() != "EOF" {
+				if err != nil && !errors.Is(err, io.EOF) {
 					return err
 				}
 				if len(result) == 0 {

cmd/operator/multisign_test.go

@@ -118,8 +118,8 @@ func TestDoSignAndPost_AutoSign_Success(t *testing.T) {
 
 	autoSign = true
 	signerAddress = "addr_A"
-	_, rawPriv, _ := ed25519.GenerateKey(nil)
 
+	pubKey, rawPriv, _ := ed25519.GenerateKey(nil)
 	privateKey = &mock.PrivateKeyMock{
 		ScalarMock: func() crypto.Scalar {
 			return &mock.ScalarMock{
@@ -129,22 +129,35 @@ func TestDoSignAndPost_AutoSign_Success(t *testing.T) {
 			}
 		},
 	}
+
+	expectedAddress := walletPubKeyConverter.Encode(pubKey)
+
+	var capturedBody MSApiEncoded
 	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		require.NoError(t, json.NewDecoder(r.Body).Decode(&capturedBody))
 		w.Header().Set("Content-Type", "application/json")
 		_ = json.NewEncoder(w).Encode(map[string]string{"status": "ok", "error": ""})
 	}))
 	defer srv.Close()
 	multisignAPI = srv.URL
+
 	tx := &MSApiTransaction{
 		Hash:    validHash,
 		Signers: []MSApiSigner{{Address: "addr_A", Signed: false}},
 		Raw: &transaction.Transaction{
 			Signature: make([][]byte, 0),
-			RawData:   &transaction.Transaction_Raw{},
+			RawData: &transaction.Transaction_Raw{
+				Sender: pubKey,
+			},
 		},
 	}
+
 	err := doSignAndPost(tx)
 	assert.NoError(t, err)
+
+	assert.Equal(t, expectedAddress, capturedBody.Address, "posted address should be the bech32-encoded sender pubkey")
+	assert.Len(t, tx.Raw.Signature, 1, "a signature should have been appended to the transaction")
+	assert.NotEmpty(t, tx.Raw.Signature[0], "appended signature should not be empty")
 }
 
 // --- doPostMSTransactionSignature ---

cmd/operator/multsignHelper.go

@@ -4,6 +4,7 @@ import (
 	"encoding/hex"
 	"encoding/json"
 	"fmt"
+	"io"
 	"strconv"
 	"strings"
 	"time"
@@ -158,7 +159,7 @@ func getMSApiTransaction(hash string) (*MSApiTransaction, error) {
 	result := MSApiTransaction{}
 	err = utils.GetURL(fmt.Sprintf("%s/transaction/%s", multisignAPI, hash), &result)
 	if err != nil {
-		if err.Error() == "EOF" {
+		if errors.Is(err, io.EOF) {
 			return nil, fmt.Errorf("transaction with hash %s not found in multisign API", hash)
 		}
 		return nil, err