fix: address PR reviewer comments

- Set MetricCurrentDepositNonce in GetAndStoreBatchFromEthereum for
  consistency across both bridge directions
- Use dynamic chain names for MetricBridgeDirection instead of
  hardcoded strings

Author: fbsobreira

bridges/ethKC/bridgeExecutor.go

@@ -473,6 +473,10 @@ func (executor *bridgeExecutor) GetAndStoreBatchFromEthereum(ctx context.Context
 
 	executor.batch = batch
 	executor.statusHandler.SetIntMetric(bridgeCore.MetricCurrentBatchID, safeUint64ToInt(batch.ID))
+	if len(batch.Deposits) > 0 {
+		lastDeposit := batch.Deposits[len(batch.Deposits)-1]
+		executor.statusHandler.SetIntMetric(bridgeCore.MetricCurrentDepositNonce, safeUint64ToInt(lastDeposit.Nonce))
+	}
 
 	return nil
 }

bridges/ethKC/bridgeExecutor_test.go

@@ -401,7 +401,8 @@ func TestEthToKCBridgeExecutor_GetAndStoreBatchFromEthereum(t *testing.T) {
 		expectedBatch := &bridgeCore.TransferBatch{
 			ID: providedNonce,
 			Deposits: []*bridgeCore.DepositTransfer{
-				{},
+				{Nonce: 100},
+				{Nonce: 101},
 			},
 		}
 		args.EthereumClient = &bridgeTests.EthereumClientStub{
@@ -420,6 +421,7 @@ func TestEthToKCBridgeExecutor_GetAndStoreBatchFromEthereum(t *testing.T) {
 		assert.True(t, expectedBatch == executor.GetStoredBatch()) // pointer testing
 		assert.True(t, expectedBatch == executor.batch)
 		assert.Equal(t, int(providedNonce), statusHandler.GetIntMetric(bridgeCore.MetricCurrentBatchID))
+		assert.Equal(t, 101, statusHandler.GetIntMetric(bridgeCore.MetricCurrentDepositNonce))
 	})
 	t.Run("should add deposits metadata for sc calls", func(t *testing.T) {
 		t.Parallel()

factory/ethKcBridgeComponents.go

@@ -519,7 +519,7 @@ func (components *ethKleverBridgeComponents) createEthereumToKleverBlockchainBri
 		return err
 	}
 
-	components.ethtoKleverStatusHandler.SetStringMetric(core.MetricBridgeDirection, "ETH->KC")
+	components.ethtoKleverStatusHandler.SetStringMetric(core.MetricBridgeDirection, ethtokleverName)
 
 	timeForTransferExecution := time.Second * time.Duration(args.Configs.GeneralConfig.Eth.IntervalToWaitForTransferInSeconds)
 
@@ -589,7 +589,7 @@ func (components *ethKleverBridgeComponents) createKCToEthereumBridge(args ArgsE
 		return err
 	}
 
-	components.kcToEthStatusHandler.SetStringMetric(core.MetricBridgeDirection, "KC->ETH")
+	components.kcToEthStatusHandler.SetStringMetric(core.MetricBridgeDirection, kcToEthName)
 
 	timeForWaitOnEthereum := time.Second * time.Duration(args.Configs.GeneralConfig.Eth.IntervalToWaitForTransferInSeconds)