Skip to content

Commit af25cef

Browse files
committed
fix: address second round of PR review feedback
- Set idempotentHint to false on chain write tools (nonce-dependent) - Fix getKDAInfo test mock to match KDAData interface shape
1 parent 7e8c1a3 commit af25cef

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

src/chain/client.test.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -195,17 +195,23 @@ describe('KleverChainClient', () => {
195195
describe('getKDAInfo', () => {
196196
it('fetches KDA token info for an address', async () => {
197197
const kdaData = {
198-
balance: 500000,
199-
frozenBalance: 0,
200-
lastClaim: { timestamp: 0, epoch: 0 },
198+
address: 'klv1test',
199+
asset: 'USDT-A1B2',
200+
userKDA: {
201+
balance: 500000,
202+
frozenBalance: 0,
203+
LastClaim: { timestamp: 0, epoch: 0 },
204+
},
201205
};
202206

203207
mockFetch.mockResolvedValueOnce(
204208
jsonResponse({ data: kdaData, error: '', code: 'successful' })
205209
);
206210

207211
const result = await client.getKDAInfo('klv1test', 'USDT-A1B2');
208-
expect(result.balance).toBe(500000);
212+
expect(result.address).toBe('klv1test');
213+
expect(result.asset).toBe('USDT-A1B2');
214+
expect(result.userKDA.balance).toBe(500000);
209215
expect(mockFetch).toHaveBeenCalledWith(
210216
'https://node.testnet.klever.org/address/klv1test/kda?asset=USDT-A1B2',
211217
expect.anything()

src/mcp/server.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,7 @@ export class KleverMCPServer {
520520
title: 'Build Transfer Transaction',
521521
readOnlyHint: false,
522522
destructiveHint: false,
523-
idempotentHint: true,
523+
idempotentHint: false,
524524
openWorldHint: true,
525525
},
526526
},
@@ -554,7 +554,7 @@ export class KleverMCPServer {
554554
title: 'Build Deploy SC Transaction',
555555
readOnlyHint: false,
556556
destructiveHint: false,
557-
idempotentHint: true,
557+
idempotentHint: false,
558558
openWorldHint: true,
559559
},
560560
},
@@ -596,7 +596,7 @@ export class KleverMCPServer {
596596
title: 'Build Invoke SC Transaction',
597597
readOnlyHint: false,
598598
destructiveHint: false,
599-
idempotentHint: true,
599+
idempotentHint: false,
600600
openWorldHint: true,
601601
},
602602
},
@@ -625,7 +625,7 @@ export class KleverMCPServer {
625625
title: 'Build Freeze KLV Transaction',
626626
readOnlyHint: false,
627627
destructiveHint: false,
628-
idempotentHint: true,
628+
idempotentHint: false,
629629
openWorldHint: true,
630630
},
631631
},

0 commit comments

Comments
 (0)