SA Fixes

Author: camilo

src/include/mat.hpp renamed to check/mat.hpp

@@ -1,7 +1,7 @@
 #include <iostream>
 #include <qlibs.h>
 #include <cmath>
-#include <include/mat.hpp>
+//#include <include/mat.hpp>
 
 using namespace std;
 using namespace qlibs;
@@ -417,7 +417,7 @@ void test_ffmath(void)
     std::cout << ffmath::copysign( ffmath::getNan(), -2.0f ) << std::endl;
     std::cout << ffmath::copysign( ffmath::getInf(), -2.0f ) << std::endl;
 }
-
+/*
 void test_mat( void )
 {
     cout<<"MAT TEST"<<endl;
@@ -449,7 +449,7 @@ void test_mat( void )
     (x*ix).display();
 
 }
-
+*/
 void test_interp1( void )
 {
     real_t tx[] = { 1.0f, 2.0f, 3.0f, 4.0f };
@@ -594,7 +594,7 @@ int main()
     test_fp16();
     test_tdl();
 
-    test_mat();
+    //test_mat();
     test_interp1();
     test_fis();
     test_fis2();

check/qlibs_cpp_test.cpp

@@ -2228,9 +2228,6 @@
         <file>
             <name>$PROJ_DIR$\..\src\include\ltisys.hpp</name>
         </file>
-        <file>
-            <name>$PROJ_DIR$\..\src\include\mat.hpp</name>
-        </file>
         <file>
             <name>$PROJ_DIR$\..\src\include\numa.hpp</name>
         </file>

check/sa_check.ewp

@@ -2958,9 +2958,6 @@
         <file>
             <name>$PROJ_DIR$\..\src\include\ltisys.hpp</name>
         </file>
-        <file>
-            <name>$PROJ_DIR$\..\src\include\mat.hpp</name>
-        </file>
         <file>
             <name>$PROJ_DIR$\..\src\include\numa.hpp</name>
         </file>

check/sa_check.ewt

@@ -247,7 +247,12 @@ namespace qlibs {
                 return delay( xInput );
             }
 
-            constexpr size_t getNumberOfDelays() const noexcept {
+            /**
+            * @brief Returns the number of delay steps configured for this instance.
+            * 
+            * @return The number of delays (equal to the template parameter).
+            */
+            size_t getNumberOfDelays() const noexcept {
                 return numberOfDelays;
             }
     };

src/include/ltisys.hpp

@@ -37,7 +37,6 @@ namespace qlibs {
             real_t *rd{ nullptr };
             real_t *wr{ nullptr };
             size_t itemCount{ 0U };
-            const real_t undefined{ 0.0_re/0.0_re }; // skipcq: CXX-W2010
 
             void insertNewest( const real_t sample ) noexcept;
             void removeOldest( void ) noexcept;
@@ -131,7 +130,7 @@ namespace qlibs {
             * @param[in] index The requested delay index
             * @return The requested value from the TDL
             */
-            const real_t& operator[]( int index ) noexcept;
+            real_t operator[]( int index ) noexcept;
 
             /**
             * @brief Insert a new sample to the TDL removing the oldest sample

src/include/tdl.hpp

@@ -284,7 +284,7 @@ bool smithPredictor::updatePrediction( const real_t ut,
     const real_t yt_hat = modelDelay->delay( yt_hat_d );
     const real_t ep_hat = yt - yt_hat;
 
-    yp_hat = yt_hat_d + ( filter ? filter->excite( ep_hat ) : ep_hat );
+    yp_hat = yt_hat_d + ( ( nullptr != filter ) ? filter->excite( ep_hat ) : ep_hat );
     return true;
 }
 /*============================================================================*/

src/ltisys.cpp

@@ -53,9 +53,14 @@ real_t tdl::getRecent( void ) const noexcept
 /*============================================================================*/
 real_t tdl::getAtIndex( const size_t i ) const noexcept
 {
+    size_t j = i;
+
+    if ( j >= itemCount ) {
+        j = itemCount - 1U;
+    }
     /*cstat -MISRAC++2008-5-0-3*/
-    return ( ( wr >= rd ) && ( ( head + i ) >= wr ) ) ? rd[ itemCount - i ]
-                                                      : *( rd - i );
+    return ( ( wr >= rd ) && ( ( head + j ) >= wr ) ) ? rd[ itemCount - j ]
+                                                      : *( rd - j );
     /*cstat +MISRAC++2008-5-0-3*/
 }
 /*============================================================================*/
@@ -65,23 +70,13 @@ void tdl::insertSample( const real_t sample ) noexcept
     insertNewest( sample );
 }
 /*============================================================================*/
-const real_t& tdl::operator[]( int index ) noexcept
+real_t tdl::operator[]( int index ) noexcept
 {
-    const size_t i = static_cast<size_t>( index );
-    /*cstat -MISRAC++2008-6-6-5*/
-    if ( ( index >= 0 ) && ( i < itemCount ) ) {
-        /*cstat -MISRAC++2008-5-0-3*/
-        return ( ( wr >= rd ) && ( ( head + i ) >= wr ) ) ? rd[ itemCount - i ]
-                                                          : *( rd - i );
-        /*cstat +MISRAC++2008-5-0-3*/
-    }
-    else if ( -1 == index ) {
-        return ( ( rd + 1U ) >= tail ) ? head[ 0 ] : rd[ 1 ];
+    if ( index < 0 ) {
+        index = -index;
     }
-    else {
-        return undefined;
-    }
-    /*cstat +MISRAC++2008-6-6-5*/
+
+    return getAtIndex( static_cast<size_t>( index ) );
 }
 /*============================================================================*/
 /*! @endcond  */