Skip to content

Commit a9380ea

Browse files
committed
chore: remove required status checks to allow semantic releases
1 parent 716d190 commit a9380ea

File tree

1 file changed

+4
-33
lines changed

1 file changed

+4
-33
lines changed

.github/terraform/main.tf

Lines changed: 4 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -80,26 +80,6 @@ resource "github_repository_ruleset" "main" {
8080
}
8181
}
8282

83-
bypass_actors {
84-
actor_type = "RepositoryRole"
85-
86-
# Allow repository admins to manually bypass checks in PRs.
87-
#
88-
# Actor IDs by role: maintain -> 2, write -> 4, admin -> 5.
89-
#
90-
# See
91-
# https://registry.terraform.io/providers/integrations/github/latest/docs/resources/repository_ruleset#RepositoryRole-1.
92-
actor_id = 5
93-
94-
# Don't be too strict about required checks. Allow bypass actors to bypass them:
95-
#
96-
# - when merging pull requests (requires manual confirmation on the PR page)
97-
#
98-
# - when pushing directly to main (bypass happens automatically, though a warning will be
99-
# printed during `git push`)
100-
bypass_mode = "always"
101-
}
102-
10383
rules {
10484
# Require bypass permission to create/delete the default branch.
10585
creation = true
@@ -111,19 +91,10 @@ resource "github_repository_ruleset" "main" {
11191
# Prevent force-pushes to the default branch.
11292
non_fast_forward = true
11393

114-
# Require status checks to pass before merging PRs.
115-
required_status_checks {
116-
# Require checks to pass with the latest code.
117-
strict_required_status_checks_policy = true
118-
119-
required_check {
120-
context = "lint"
121-
}
122-
123-
required_check {
124-
context = "check-types"
125-
}
126-
}
94+
# Note - it would be nice to have required status checks, but this would add some
95+
# additional overhead to support automatic release commits with
96+
# `python-semantic-release`. See
97+
# https://github.com/python-semantic-release/python-semantic-release/issues/311.
12798
}
12899
}
129100

0 commit comments

Comments
 (0)