fix: remove extraneous tmp-promise dependency (#18)

* Remove tmp-promise in favor of standard tmp

* Replace tmp-promise usages with tmp

Co-authored-by: Kevin Montag <[email protected]>

Author: kmontag

index.js

@@ -1,7 +1,7 @@
 const fs = require('fs');
 const { pbjs, pbts } = require('protobufjs-cli');
 const protobuf = require('protobufjs');
-const tmp = require('tmp-promise');
+const tmp = require('tmp');
 const validateOptions = require('schema-utils').validate;
 
 const { getOptions } = require('loader-utils');
@@ -83,16 +83,23 @@ const execPbts = (resourcePath, pbtsOptions, compiledContent, callback) => {
 
   // pbts CLI only supports streaming from stdin without a lot of
   // duplicated logic, so we need to use a tmp file. :(
-  tmp
-    .file({ postfix: '.js' })
+  new Promise((resolve, reject) => {
+    tmp.file({ postfix: '.js' }, (err, compiledFilename) => {
+      if (err) {
+        reject(err);
+      } else {
+        resolve(compiledFilename);
+      }
+    });
+  })
     .then(
-      (o) =>
+      (compiledFilename) =>
         new Promise((resolve, reject) => {
-          fs.write(o.fd, compiledContent, (err) => {
+          fs.writeFile(compiledFilename, compiledContent, (err) => {
             if (err) {
               reject(err);
             } else {
-              resolve(o.path);
+              resolve(compiledFilename);
             }
           });
         })
@@ -152,22 +159,28 @@ module.exports = function protobufJsLoader(source) {
     validateOptions(schema, options, { name: 'protobufjs-loader' });
 
     /** @type { string } */
-    let filename;
-    tmp
-      .file()
-      .then((o) => {
-        filename = o.path;
-        return new Promise((resolve, reject) => {
-          fs.write(o.fd, source, (err, bytesWritten) => {
-            if (err) {
-              reject(err);
-            } else {
-              resolve(bytesWritten);
-            }
-          });
-        });
-      })
-      .then(() => {
+    new Promise((resolve, reject) => {
+      tmp.file((err, filename) => {
+        if (err) {
+          reject(err);
+        } else {
+          resolve(filename);
+        }
+      });
+    })
+      .then(
+        (filename) =>
+          new Promise((resolve, reject) => {
+            fs.writeFile(filename, source, (err) => {
+              if (err) {
+                reject(err);
+              } else {
+                resolve(filename);
+              }
+            });
+          })
+      )
+      .then((filename) => {
         const { paths } = options;
 
         const loadDependencies = new Promise((resolve, reject) => {

package-lock.json

@@ -30,7 +30,7 @@
     "protobufjs": "^7.0.0",
     "protobufjs-cli": "^1.0.0",
     "schema-utils": "^4.0.0",
-    "tmp-promise": "^1.0.4"
+    "tmp": "^0.2.1"
   },
   "devDependencies": {
     "@types/chai": "^4.3.1",
@@ -54,7 +54,6 @@
     "prettier": "^2.7.1",
     "semantic-release": "^19.0.3",
     "semver": "^7.1.2",
-    "tmp": "^0.2.1",
     "typescript": "^4.7.4",
     "uglify-js": "^3.16.2",
     "webpack": "^5.0.0",