Fix incorrect target handling in search comment suggestion form.

Author: knadh

site/results.html

@@ -28,7 +28,7 @@ <h3 class="title">{{ r.content | join(sep=", ") }}</h3>
 
                         <div class="toolbar">
                             {% if consts.enable_submissions %}
-                            <a href="#" data-from="{{ r.guid }}" class="edit" title="{{ i18n.public_suggestEdit }}"><img src="/static/edit.svg?v={{ asset_ver }}" alt="{{ i18n.public_suggestEdit }}"></a>
+                            <a href="#" data-edit-from="{{ r.guid }}" class="edit" title="{{ i18n.public_suggestEdit }}"><img src="/static/edit.svg?v={{ asset_ver }}" alt="{{ i18n.public_suggestEdit }}"></a>
                             {% endif %}
                             <a href="#{{ shareGuid }}" data-share-guid="{{ shareGuid }}" title="Share link"><img src="/static/share.svg?v={{ asset_ver }}" alt="Share link"></a>
                         </div>
@@ -65,7 +65,7 @@ <h3 class="title">{{ r.content | join(sep=", ") }}</h3>
                                 </a>
                             {% endif %}
                             {% if consts.enable_submissions %}
-                                <a href="#" data-from="{{ r.guid }}" data-to="{{ d.guid }}" class="edit" title="{{ i18n.public_suggestEdit | default(value="Suggest edit") }}">
+                                <a href="#" data-edit-from="{{ r.guid }}" data-edit-to="{{ d.guid }}" class="edit" title="{{ i18n.public_suggestEdit | default(value="Suggest edit") }}">
                                     <img src="/static/edit.svg?v={{ asset_ver }}" alt="{{ i18n.public_suggestEdit }}">
                                 </a>
                             {% endif %}

site/static/main.js

@@ -156,10 +156,9 @@
 
 // Edit form.
 (() => {
-  document.querySelectorAll(".edit").forEach((o) => {
-    o.onclick = ((e) => {
+  document.querySelectorAll("a[data-edit-from]").forEach((btn) => {
+    btn.onclick = ((e) => {
       e.preventDefault();
-      const btn = e.target;
 
       // Form is already open.
       if (btn.close) {
@@ -168,7 +167,7 @@
       }
 
       const form = document.querySelector(".form-comments").cloneNode(true);
-      o.parentNode.appendChild(form);
+      btn.parentNode.appendChild(form);
       form.style.display = "block";
 
       const txt = form.querySelector("textarea");
@@ -192,8 +191,8 @@
             "Content-Type": "application/json"
           },
           body: JSON.stringify({
-            from_guid: btn.dataset.from,
-            to_guid: btn.dataset.to,
+            from_guid: btn.dataset.editFrom,
+            to_guid: btn.dataset.editTo,
             comments: txt.value
           })
         }).catch((err) => {