Tests are extremely flakey and make contribution harder

[dprotaso]

I'm seeing
channel-reconciler-tests-ssl_eventing-kafka-broker_main prow job flake very hard on many different PRs.

You can see the stats here:
https://prow.knative.dev/job-history/gs/knative-prow/pr-logs/directory/channel-reconciler-tests-ssl_eventing-kafka-broker_main

Specifically it is always test/e2e_new_channel: TestChannelConformance/Knative_Channel_Specification_-_Data_Plane/Delivery_Spec_1/Assert/Conformance_Channels_SHOULD_support_various_retry_configuration_parameters:_[the_maximum_number_of_retries]

I think it's worth disabling the test until it can be properly fixed.

[dprotaso]

Other failing tests are visible here: #4512

integration-tests_eventing-kafka-broker_main::TestSacuraSinkSourceJob

reconciler-tests_eventing-kafka-broker_main - the failing test here is the same as above channel-reconciler-tests-ssl_eventing-kafka-broker_main

reconciler-tests-keda_eventing-kafka-broker_main:: TestBrokerDispatcherKedaScalingSSL

[dprotaso]

Another flake

https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-extensions_eventing-kafka-broker/4520/unit-tests_eventing-kafka-broker_main/1965785887358849024

unit-tests_eventing-kafka-broker_main - dev.knative.eventing.kafka.broker.dispatcherloom.LoomKafkaConsumerTest: checkTaskQueueIsEmptyAfterClose(VertxTestContext)

[matzew]

I think @Cali0707 and @maschmid wanted to look at some of those flakes.

[dprotaso]

1.19 point release failed because of integration-tests_eventing-kafka-broker_main::TestSacuraSinkSourceJob failure

https://prow.knative.dev/view/gs/knative-prow/logs/release_eventing-kafka-broker_release-1.19_periodic/1967889568241815552

[Cali0707]

@pierDipi any ideas what could be causing this error in sacura?

         2025/09/16 11:27:37 Metrics server closed
        2025/09/16 11:27:37 Waiting for attacker to finish ...
        2025/09/16 11:27:37 Waiting for received channel signal
        2025/09/16 11:27:37 Waiting for sent channel signal
        2025/09/16 11:27:37 http: panic serving 10.20.7.8:38512: send on closed channel
        goroutine 1167 [running]:
        net/http.(*conn).serve.func1()
        	net/http/server.go:1947 +0xbe
        panic({0xa4b480?, 0xbee350?})
        	runtime/panic.go:785 +0x132
        github.com/pierdipi/sacura.StartReceiver.func2({0xbf72a0, 0xc0001356d0}, 0xc0005760c0, 0xc00070b400)
        	github.com/pierdipi/sacura/receiver.go:94 +0x46d
        github.com/pierdipi/sacura.startReceiver.func1({0xbf6320, 0xc000756460}, 0xc00070b400)
        	github.com/pierdipi/sacura/receiver.go:243 +0x11c
        net/http.HandlerFunc.ServeHTTP(0x410865?, {0xbf6320?, 0xc000756460?}, 0xc000756401?)
        	net/http/server.go:2220 +0x29
        net/http.serverHandler.ServeHTTP({0xbf3b10?}, {0xbf6320?, 0xc000756460?}, 0x6?)
        	net/http/server.go:3210 +0x8e
        net/http.(*conn).serve(0xc000703830, {0xbf7268, 0xc0000c8150})
        	net/http/server.go:2092 +0x5d0
        created by net/http.(*Server).Serve in goroutine 16
        	net/http/server.go:3360 +0x485