Fix Server TLS settings so it works with Istio 1.27 (#1462)

Co-authored-by: Dave Protasowski <dprotaso@gmail.com>

Author: knative-prow-robot

pkg/reconciler/ingress/ingress_test.go

@@ -125,11 +125,8 @@ var (
 			Protocol: "HTTPS",
 		},
 		Tls: &istiov1beta1.ServerTLSSettings{
-			Mode:               istiov1beta1.ServerTLSSettings_SIMPLE,
-			ServerCertificate:  corev1.TLSCertKey,
-			PrivateKey:         corev1.TLSPrivateKeyKey,
-			CredentialName:     "secret0",
-			MinProtocolVersion: istiov1beta1.ServerTLSSettings_TLSV1_2,
+			Mode:           istiov1beta1.ServerTLSSettings_SIMPLE,
+			CredentialName: "secret0",
 		},
 	}
 	originGateways = map[string]string{
@@ -210,11 +207,8 @@ var (
 			Protocol: "HTTPS",
 		},
 		Tls: &istiov1beta1.ServerTLSSettings{
-			Mode:               istiov1beta1.ServerTLSSettings_SIMPLE,
-			ServerCertificate:  "tls.crt",
-			PrivateKey:         "tls.key",
-			CredentialName:     "secret0",
-			MinProtocolVersion: istiov1beta1.ServerTLSSettings_TLSV1_2,
+			Mode:           istiov1beta1.ServerTLSSettings_SIMPLE,
+			CredentialName: "secret0",
 		},
 	}
 
@@ -226,11 +220,8 @@ var (
 			Protocol: "HTTPS",
 		},
 		Tls: &istiov1beta1.ServerTLSSettings{
-			Mode:               istiov1beta1.ServerTLSSettings_SIMPLE,
-			ServerCertificate:  "tls.crt",
-			PrivateKey:         "tls.key",
-			CredentialName:     "secret0",
-			MinProtocolVersion: istiov1beta1.ServerTLSSettings_TLSV1_2,
+			Mode:           istiov1beta1.ServerTLSSettings_SIMPLE,
+			CredentialName: "secret0",
 		},
 	}
 
@@ -264,11 +255,8 @@ var (
 			Protocol: "HTTPS",
 		},
 		Tls: &istiov1beta1.ServerTLSSettings{
-			Mode:               istiov1beta1.ServerTLSSettings_SIMPLE,
-			ServerCertificate:  "tls.crt",
-			PrivateKey:         "tls.key",
-			CredentialName:     "other-secret",
-			MinProtocolVersion: istiov1beta1.ServerTLSSettings_TLSV1_2,
+			Mode:           istiov1beta1.ServerTLSSettings_SIMPLE,
+			CredentialName: "other-secret",
 		},
 	}
 	irrelevantServer1 = &istiov1beta1.Server{

pkg/reconciler/ingress/resources/gateway.go

@@ -191,12 +191,8 @@ func makeWildcardTLSGateways(originWildcardSecrets map[string]*corev1.Secret,
 				Protocol: "HTTPS",
 			},
 			Tls: &istiov1beta1.ServerTLSSettings{
-				Mode:              istiov1beta1.ServerTLSSettings_SIMPLE,
-				ServerCertificate: corev1.TLSCertKey,
-				PrivateKey:        corev1.TLSPrivateKeyKey,
-				CredentialName:    credentialName,
-				// TODO: Drop this when all supported Istio version uses TLS v1.2 by default.
-				MinProtocolVersion: istiov1beta1.ServerTLSSettings_TLSV1_2,
+				Mode:           istiov1beta1.ServerTLSSettings_SIMPLE,
+				CredentialName: credentialName,
 			},
 		}}
 		gvk := schema.GroupVersionKind{Version: "v1", Kind: "Secret"}
@@ -343,12 +339,8 @@ func MakeTLSServers(ing *v1alpha1.Ingress, visibility v1alpha1.IngressVisibility
 				Protocol: "HTTPS",
 			},
 			Tls: &istiov1beta1.ServerTLSSettings{
-				Mode:              istiov1beta1.ServerTLSSettings_SIMPLE,
-				ServerCertificate: corev1.TLSCertKey,
-				PrivateKey:        corev1.TLSPrivateKeyKey,
-				CredentialName:    credentialName,
-				// TODO: Drop this when all supported Istio version uses TLS v1.2 by default.
-				MinProtocolVersion: istiov1beta1.ServerTLSSettings_TLSV1_2,
+				Mode:           istiov1beta1.ServerTLSSettings_SIMPLE,
+				CredentialName: credentialName,
 			},
 		}
 	}