Skip to content

Remove the additional explicit wait "hack" in progress bar #1965

Open
@cardil

Description

@cardil

The additional explicit wait "hack" in the progress bar should be removed. If your UI has a lot of progress bars, this wait will be visible.

https://github.com/knative/client-pkg/blob/cf1573f9363107e30399011565bf11f95bac52d7/pkg/output/tui/progress.go#L188-L193

But, I don't see a way, with the current API of bubbles' progress, to achieve it otherwise...

Without the wait, we get UI with progress bars that are never 100% completed. See example: knative/client-pkg#162 (comment)

Originally posted by @cardil in knative/client-pkg#162 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.triage/acceptedIssues which should be fixed (post-triage)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions