Skip to content

Commit 048d3b1

Browse files
[release-1.12] Fix mtbroker-filter to proxy response headers (#7632)
* Fix mtbroker-filter to proxy response headers * Switch to utils.PassThroughHeaders --------- Co-authored-by: Christoph Stäbler <[email protected]>
1 parent 35d5618 commit 048d3b1

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

pkg/broker/filter/filter_handler.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,8 @@ func (h *Handler) writeResponse(ctx context.Context, writer http.ResponseWriter,
308308
writer.WriteHeader(http.StatusBadGateway)
309309
return http.StatusBadGateway, errors.New("received a non-empty response not recognized as CloudEvent. The response MUST be either empty or a valid CloudEvent")
310310
}
311-
writeHeaders(dispatchInfo.ResponseHeader, writer) // Proxy original Response Headers for downstream use
311+
312+
writeHeaders(utils.PassThroughHeaders(dispatchInfo.ResponseHeader), writer) // Proxy original Response Headers for downstream use
312313
h.logger.Debug("Response doesn't contain a CloudEvent, replying with an empty response", zap.Any("target", target))
313314
writer.WriteHeader(dispatchInfo.ResponseCode)
314315
return dispatchInfo.ResponseCode, nil
@@ -333,7 +334,7 @@ func (h *Handler) writeResponse(ctx context.Context, writer http.ResponseWriter,
333334
defer eventResponse.Finish(nil)
334335

335336
// Proxy the original Response Headers for downstream use
336-
writeHeaders(dispatchInfo.ResponseHeader, writer)
337+
writeHeaders(utils.PassThroughHeaders(dispatchInfo.ResponseHeader), writer)
337338

338339
if err := cehttp.WriteResponseWriter(ctx, eventResponse, dispatchInfo.ResponseCode, writer); err != nil {
339340
return http.StatusInternalServerError, fmt.Errorf("failed to write response event: %w", err)

0 commit comments

Comments
 (0)