trigger reconciliation if previous failed (#2196)

k15r · knative-prow-robot · commit 5945dc56ecef · 2019-11-18T10:34:08.000-08:00
diff --git a/contrib/natss/pkg/reconciler/dispatcher/natsschannel.go b/contrib/natss/pkg/reconciler/dispatcher/natsschannel.go
@@ -130,7 +130,9 @@ func (r *Reconciler) Reconcile(ctx context.Context, key string) error {
 		logging.FromContext(ctx).Error("Failed to update NatssChannel status", zap.Error(updateStatusErr))
 		return updateStatusErr
 	}
-	return nil
+
+	// trigger new reconciliation if the previous one failed
+	return reconcileErr
 }
 
 func (r *Reconciler) reconcile(ctx context.Context, natssChannel *v1alpha1.NatssChannel) error {

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,9 @@ func (r *Reconciler) Reconcile(ctx context.Context, key string) error {`
`130`	`130`	`logging.FromContext(ctx).Error("Failed to update NatssChannel status", zap.Error(updateStatusErr))`
`131`	`131`	`return updateStatusErr`
`132`	`132`	`}`
`133`		`- return nil`
	`133`	`+`
	`134`	`+ // trigger new reconciliation if the previous one failed`
	`135`	`+ return reconcileErr`
`134`	`136`	`}`
`135`	`137`
`136`	`138`	`func (r Reconciler) reconcile(ctx context.Context, natssChannel v1alpha1.NatssChannel) error {`