[release-1.14] Avoid fatal errors for unknown features flags that can be added in a future release (#8052)

knative-prow-robot · pierDipi · web-flow · commit 5f921643f19b · 2024-06-27T16:37:46.000Z
Avoid fatal errors for unknown features flags that can be added in a future release

Signed-off-by: Pierangelo Di Pilato &lt;pierdipi@redhat.com&gt;
Co-authored-by: Pierangelo Di Pilato &lt;pierdipi@redhat.com&gt;
diff --git a/pkg/apis/feature/features.go b/pkg/apis/feature/features.go
@@ -18,6 +18,7 @@ package feature
 
 import (
 	"fmt"
+	"log"
 	"strings"
 
 	corev1 "k8s.io/api/core/v1"
@@ -148,7 +149,8 @@ func NewFlagsConfigFromMap(data map[string]string) (Flags, error) {
 		} else if strings.Contains(k, NodeSelectorLabel) {
 			flags[sanitizedKey] = Flag(v)
 		} else {
-			return flags, fmt.Errorf("cannot parse the feature flag '%s' = '%s'", k, v)
+			flags[k] = Flag(v)
+			log.Printf("Warning: unknown feature flag value %q=%q\n", k, v)
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@ package feature`
`18`	`18`
`19`	`19`	`import (`
`20`	`20`	`"fmt"`
	`21`	`+ "log"`
`21`	`22`	`"strings"`
`22`	`23`
`23`	`24`	`corev1 "k8s.io/api/core/v1"`
`@@ -148,7 +149,8 @@ func NewFlagsConfigFromMap(data map[string]string) (Flags, error) {`
`148`	`149`	`} else if strings.Contains(k, NodeSelectorLabel) {`
`149`	`150`	`flags[sanitizedKey] = Flag(v)`
`150`	`151`	`} else {`
`151`		`- return flags, fmt.Errorf("cannot parse the feature flag '%s' = '%s'", k, v)`
	`152`	`+ flags[k] = Flag(v)`
	`153`	`+ log.Printf("Warning: unknown feature flag value %q=%q\n", k, v)`
`152`	`154`	`}`
`153`	`155`	`}`
`154`	`156`