Skip to content

[WIP] Delete dynamic controller on CRD uninstall #4814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aavarghese wants to merge 1 commit into from
Closed

[WIP] Delete dynamic controller on CRD uninstall #4814

aavarghese wants to merge 1 commit into from

Conversation

@aavarghese
Copy link
Contributor

@aavarghese aavarghese commented Jan 29, 2021

Signed-off-by: Ansu Varghese [email protected]

Fixes #4611

Proposed Changes

Release Note

Docs

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 29, 2021
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jan 29, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 29, 2021
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jan 29, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aavarghese
To complete the pull request process, please assign slinkydeveloper after the PR has been reviewed.
You can assign the PR to them by writing /assign @slinkydeveloper in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lgtm-com
Copy link

lgtm-com bot commented Jan 29, 2021

This pull request introduces 1 alert when merging 55039cf into a6635bb - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@aavarghese
Copy link
Contributor Author

aavarghese commented Jan 29, 2021

Discussion in https://knative.slack.com/archives/C93E33SN8/p1611947862149300.

I'm blocked for now since I'm unable to stop the informer.

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 8, 2021

@aavarghese: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2021
Base automatically changed from master to main March 8, 2021 17:40
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Mar 8, 2021

@aavarghese: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-reconciler-tests 55039cf link /test pull-knative-eventing-reconciler-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@github-actions
Copy link

github-actions bot commented Jun 7, 2021

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2021
@github-actions github-actions bot closed this Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nlopezgi nlopezgi Awaiting requested review from nlopezgi

@zhongduo zhongduo Awaiting requested review from zhongduo

Assignees

No one assigned

Labels

cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uninstalled Event Source results in "Failed to list *v1.Source: the server could not find the requested resource"

2 participants

@aavarghese @knative-prow-robot