[flaky] pkg/kncloudevents.TestDispatchMessageToTLSEndpoint

[creydr]

• Test name: kncloudevents.TestDispatchMessageToTLSEndpoint
• Repository: eventing
• Flaky run: https://prow.knative.dev/view/gs/knative-prow/logs/release_eventing_main_periodic/1716789998008668160

=== RUN   TestDispatchMessageToTLSEndpoint
    logger.go:130: 2023-10-24T12:29:12.163Z	DEBUG	eventingtls/eventingtls.go:106	Loading key pair	{"tls.secret": "knative-tests/tls-secret"}
    logger.go:130: 2023-10-24T12:29:12.170Z	DEBUG	eventingtls/eventingtls.go:114	certificate stored	{"tls.secret": "knative-tests/tls-secret"}
    event_dispatcher_test.go:962: 
        	Error Trace:	/home/prow/go/src/knative.dev/eventing/pkg/kncloudevents/event_dispatcher_test.go:962
        	Error:      	Expected nil, but got: &fmt.wrapError{msg:"unable to complete request to https://localhost:8334/: Post \"https://localhost:8334/\": dial tcp 127.0.0.1:8334: connect: connection refused", err:(*url.Error)(0xc0007e2630)}
        	Test:       	TestDispatchMessageToTLSEndpoint
--- FAIL: TestDispatchMessageToTLSEndpoint (0.52s)
FAIL pkg/kncloudevents.TestDispatchMessageToTLSEndpoint (0.52s)

[Cali0707]

@creydr do you think using port 0 would be a reasonable fix for these tests (so that we always get an unused port?)

[Cali0707]

/triage accepted

[satyampsoni]

/assign

[satyampsoni]

@Cali0707 @creydr I have some questions before moving forward with this issue.

1. Is There a Specific Reason for the Fixed Port (e.g., 8443) external system or component depending on the fixed port?
2. What Testing Has Been Done With Dynamic Port Assignment?
3. Are There Any Security Concerns that I should be aware of With Dynamic Port Assignment?
4. How dynamic port assignment might impact TLS certificate generation, configuration, and validation.

[creydr]

Hi @satyampsoni,
thanks for taking this. My comments below:

1. Is There a Specific Reason for the Fixed Port (e.g., 8443) external system or component depending on the fixed port?

No

2. What Testing Has Been Done With Dynamic Port Assignment?

None. As pointed out by @Cali0707 this could be one way to fix the flakyness

3. Are There Any Security Concerns that I should be aware of With Dynamic Port Assignment?

Not that I am aware of

4. How dynamic port assignment might impact TLS certificate generation, configuration, and validation.

It should not, as the certificates are based on the host names.

I hope this helps.

[satyampsoni]

Thank you @creydr. I have made the changes, will push the PR in sometime.