Skip to content

Provide configuration option for revisions becoming Unschedulable #14862

Open
@SaschaSchwarze0

Description

@SaschaSchwarze0

/area autoscale

Describe the feature

In Bubble up pod schedule errors to revision status, the Revision reconciler was changed to propagate pod scheduling issues up to the Revision. This is done whenever a scale from 0 happens but not when a scale from for example 1 happens due to this condition.

I generally can understand the reason behind this for a Knative installation where users have full control and where the cluster size is fixed.

We are running Knative as a managed service with cluster autoscaling. There is actually no way to get to a Pod that cannot be scheduled. Even if suddenly there is no capacity available for a moment, every Pod will eventually be scheduled. In our environment, revisions (temporarily) going into that status are confusing our users.

What I would like to ask for is a configuration option to turn that code path off when the flag is active and the condition's reason is Unschedulable.

If you agree that such a flag makes sense, I would be willing to PR the change. I just would need guidance on how to name the configuration option (pod-is-always-schedulable for example ?) and whether that would go into config-features or if you prefer an environment variable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/autoscalekind/featureWell-understood/specified features, ready for coding.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions