Skip to content

Commit f71f8dd

Browse files
committed
hotfix - address build errors found after fresh clone
1 parent b78e9f1 commit f71f8dd

3 files changed

Lines changed: 23 additions & 2 deletions

File tree

.github/workflows/deploy.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ jobs:
3636
${{ secrets.DOCKER_USERNAME }}/kubetasker-controller:${{ github.sha }}
3737
${{ secrets.DOCKER_USERNAME }}/kubetasker-controller:latest
3838
39+
- name: Copy requirements.txt to frontend directory
40+
run: cp requirements.txt helm/kubetasker-frontend/
41+
3942
- name: Build and push Frontend
4043
uses: docker/build-push-action@v5
4144
with:

helm/kubetasker-frontend/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
FROM python:3.12-slim
44

55
# Set environment variables
6-
ENV PYTHONDONTWRITEBYTECODE 1
7-
ENV PYTHONUNBUFFERED 1
6+
ENV PYTHONDONTWRITEBYTECODE=1
7+
ENV PYTHONUNBUFFERED=1
88

99
# Set the working directory in the container
1010
WORKDIR /app

test/e2e/e2e_suite_test.go

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ var (
5353
projectRootDir string
5454
chartsRoot string
5555
testRoot string
56+
kubeconfigPath string
5657
)
5758

5859
// TestE2E runs the end-to-end (e2e) test suite for the project. These tests execute in an isolated,
@@ -98,6 +99,20 @@ var _ = BeforeSuite(func() {
9899
err = utils.LoadImageToKindClusterWithName(kindClusterName, frontendImage)
99100
ExpectWithOffset(1, err).NotTo(HaveOccurred(), "Failed to load the frontend API image into Kind")
100101

102+
By("getting the kubeconfig from Kind")
103+
cmd = exec.Command("kind", "get", "kubeconfig", "--name", kindClusterName)
104+
kubeconfig, err := utils.Run(cmd)
105+
Expect(err).NotTo(HaveOccurred(), "Failed to get kubeconfig from Kind")
106+
107+
f, err := os.CreateTemp("", "kubeconfig")
108+
Expect(err).NotTo(HaveOccurred())
109+
_, err = f.WriteString(kubeconfig)
110+
Expect(err).NotTo(HaveOccurred())
111+
err = f.Close()
112+
Expect(err).NotTo(HaveOccurred())
113+
kubeconfigPath = f.Name()
114+
os.Setenv("KUBECONFIG", kubeconfigPath)
115+
101116
By("updating helm dependencies for the umbrella chart")
102117
umbrellaChartPath := filepath.Join(chartsRoot, "kubetasker")
103118
cmd = exec.Command("helm", "dependency", "update", umbrellaChartPath)
@@ -195,6 +210,9 @@ var _ = AfterSuite(func() {
195210
// Only remove the files generated during the test, not the whole directory.
196211
_ = os.Remove(filepath.Join(projectRootDir, "kustomize", "base", "all.yaml"))
197212
_ = os.Remove(filepath.Join(projectRootDir, "kustomize", "base", "crd.yaml"))
213+
if kubeconfigPath != "" {
214+
_ = os.Remove(kubeconfigPath)
215+
}
198216
})
199217

200218
// logDebugInfoOnFailure checks if the current Ginkgo spec has failed. If it has, it captures

0 commit comments

Comments
 (0)