From a62504b432b69eab9c5aa629d2deed801677c050 Mon Sep 17 00:00:00 2001 From: KCM Date: Sat, 27 Dec 2025 16:35:33 -0600 Subject: [PATCH 1/2] chore: align code, docs, and support policy. --- README.md | 2 +- package-lock.json | 3 +-- package.json | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index e04ee5a..4ee2e82 100644 --- a/README.md +++ b/README.md @@ -22,7 +22,7 @@ By default `@knighted/module` transforms the one-to-one [differences between ES ## Requirements -- Node >= 22.21.1 +- Node 22 or 24 (tested on 22.21.1 and 24.11.1) ## Install diff --git a/package-lock.json b/package-lock.json index 40af7d1..1432a37 100644 --- a/package-lock.json +++ b/package-lock.json @@ -27,7 +27,7 @@ "typescript": "^5.9.3" }, "engines": { - "node": ">=22.21.1" + "node": ">=22.21.1 <23 || >=24 <25" } }, "node_modules/@babel/code-frame": { @@ -4194,7 +4194,6 @@ "resolved": "https://registry.npmjs.org/oxc-parser/-/oxc-parser-0.105.0.tgz", "integrity": "sha512-9O+8zEIC/7Ly519wuKVAFHbcqeZxW8bOHXXE+BZYf8BA/J53SEJNvevMH3VI0ptrs4SMPAaxOW6K1jDJTSl0cg==", "license": "MIT", - "peer": true, "dependencies": { "@oxc-project/types": "^0.105.0" }, diff --git a/package.json b/package.json index c14adbf..b50ec83 100644 --- a/package.json +++ b/package.json @@ -27,7 +27,7 @@ "#formatters/*.js": "./src/formatters/*.js" }, "engines": { - "node": ">=22.21.1" + "node": ">=22.21.1 <23 || >=24 <25" }, "engineStrict": true, "scripts": { From 4d5f416c087dca67cf64ec03727730ab99de8cf5 Mon Sep 17 00:00:00 2001 From: KCM Date: Sat, 27 Dec 2025 16:40:04 -0600 Subject: [PATCH 2/2] docs: add note about limitations. --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 4ee2e82..d387966 100644 --- a/README.md +++ b/README.md @@ -137,6 +137,9 @@ Behavior notes (defaults in parentheses) See [docs/esm-to-cjs.md](docs/esm-to-cjs.md) for deeper notes on live bindings, interop helpers, top-level await behavior, and `import.meta.main` handling. For CommonJS to ESM lowering details, read [docs/cjs-to-esm.md](docs/cjs-to-esm.md). +> [!NOTE] +> Known limitations: `with` and unshadowed `eval` are rejected when raising CJS to ESM because the rewrite would be unsound; bare specifiers are not rewritten—only relative specifiers participate in `rewriteSpecifier`. + ## Roadmap - Emit source maps and clearer diagnostics for transform choices.