fix all golangci-lint warnings

Author: RJKeevil

.golangci.yml

@@ -1,133 +1,69 @@
+version: "2"
 linters:
+  default: none
   enable:
-    # Check for pass []any as any in variadic func(...any).
-    # Rare case but saved me from debugging a few times.
     - asasalint
-
-    # I prefer plane ASCII identifiers.
-    # Symbol `∆` instead of `delta` looks cool but no thanks.
     - asciicheck
-
-    # Checks for dangerous unicode character sequences.
-    # Super rare but why not to be a bit paranoid?
     - bidichk
-
-    # Checks whether HTTP response body is closed successfully.
     - bodyclose
-
-    # Check whether the function uses a non-inherited context.
     - contextcheck
-
-    # Check for two durations multiplied together.
     - durationcheck
-
-    # Forces to not skip error check.
     - errcheck
-
-    # Checks `Err-` prefix for var and `-Error` suffix for error type.
     - errname
-
-    # Suggests to use `%w` for error-wrapping.
     - errorlint
-
-    # Checks for pointers to enclosing loop variables.
-    - exportloopref
-
-    # Forces to put `.` at the end of the comment. Code is poetry.
     - godot
-
-    # Might not be that important but I prefer to keep all of them.
-    # `gofumpt` is amazing, kudos to Daniel Marti https://github.com/mvdan/gofumpt
-    - gofmt
-    - gofumpt
-    - goimports
-
-    # Allow or ban replace directives in go.mod
-    # or force explanation for retract directives.
-    - gomoddirectives
-
-    # Powerful security-oriented linter. But requires some time to
-    # configure it properly, see https://github.com/securego/gosec#available-rules
     - gosec
-
-    # Linter that specializes in simplifying code.
-    - gosimple
-
-    # Official Go tool. Must have. 
     - govet
-
-    # Detects when assignments to existing variables are not used
-    # Last week I caught a bug with it.
     - ineffassign
-
-    # Fix all the misspells, amazing thing.
     - misspell
-
-    # Finds naked/bare returns and requires change them.
     - nakedret
-
-    # Both require a bit more explicit returns.
     - nilerr
     - nilnil
-
-    # Finds sending HTTP request without context.Context.
     - noctx
-
-    # Forces comment why another check is disabled.
-    # Better not to have //nolint: at all ;)
     - nolintlint
-
-    # Finds slices that could potentially be pre-allocated.
-    # Small performance win + cleaner code.
-    - prealloc
-
-    # Finds shadowing of Go's predeclared identifiers.
-    # I hear a lot of complaints from junior developers.
-    # But after some time they find it very useful.
     - predeclared
-
-    # Lint your Prometheus metrics name.
     - promlinter
-
-    # Checks that package variables are not reassigned.
-    # Super rare case but can catch bad things (like `io.EOF = nil`)
     - reassign
-
-    # Drop-in replacement of `golint`.
     - revive
-
-    # Somewhat similar to `bodyclose` but for `database/sql` package.
     - rowserrcheck
     - sqlclosecheck
-
-    # I have found that it's not the same as staticcheck binary :\
     - staticcheck
-
-    # Is a replacement for `golint`, similar to `revive`.
-    - stylecheck
-
-    # Check struct tags.
-    - tagliatelle
-
-    # Test-related checks. All of them are good.
-    - tenv
     - testableexamples
     - thelper
     - tparallel
-
-    # Remove unnecessary type conversions, make code cleaner
     - unconvert
-
-    # Might be noisy but better to know what is unused
     - unparam
-
-    # Must have. Finds unused declarations.
     - unused
-
-    # Detect the possibility to use variables/constants from stdlib.
     - usestdlibvars
-
-    # Finds wasted assignment statements.
     - wastedassign
-
-version: "2"
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+      - integration/testdata
+      - integration/testTarget
+      - projects/builtInProjects
+  settings:
+    nolintlint:
+      allow-unused: false
+      allow-no-explanation: []
+      require-explanation: true
+      require-specific: true
+formatters:
+  enable:
+    - gofmt
+    - gofumpt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

CHANGELOG.md

@@ -23,7 +23,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Changed
 
 - Update to new goMLX project structure (0.24.0+)
-- remove the depency on python when installing goMLX libraries
+- remove the dependency on python when installing goMLX libraries
 
 ## [0.5.5] - 2025-09-30
 

README.md

@@ -217,7 +217,7 @@ following models:
 - **Gemma Family**: `onnx-community/gemma-3-1b-it-ONNX`, `onnx-community/gemma-3-270m-it-ONNX`
 - **Phi Family**: `microsoft/Phi-3-mini-4k-instruct-onnx`, `microsoft/Phi-3.5-mini-instruct-onnx`
 
-Generative models typically use external weights, so use the downloadOptions.ExternalDataPath option when downloading the model. See the [example](./testData/downloadModels.go ) here.
+Generative models typically use external weights, so use the downloadOptions.ExternalDataPath option when downloading the model. See the [example](testdata/downloadModels.go ) here.
 
 ### Example Usage
 ````go
@@ -316,7 +316,7 @@ We is currently supported only for the **FeatureExtractionPipeline**. This can b
 {"sentence1": "The quick brown fox jumps over the lazy dog", "sentence2": "A quick brown cow jumps over a lazy caterpillar", "score": 0.5}
 ```
 
-See the [example](./testData/semanticSimilarityTest.jsonl) for a sample dataset.
+See the [example](testdata/semanticSimilarityTest.jsonl) for a sample dataset.
 
 The score is assumed to be a float between 0 and 1 that encodes the semantic similarity between the sentences, and by default a cosine similarity loss is used (see [sentence transformers](https://sbert.net/docs/package_reference/sentence_transformer/losses.html#cosinesimilarityloss)). However, you can also specify a different loss function from `goMLX` using the `XLATrainingOptions` field in the `TrainingConfig` struct. See [the training tests](./hugot_training_test.go) for examples on how to train or fine-tune feature extraction pipelines.
 

chatTemplates/chatTemplates.go chattemplates/chatTemplates.gochatTemplates/chatTemplates.go renamed to chattemplates/chatTemplates.go

@@ -1,4 +1,4 @@
-package chatTemplates
+package chattemplates
 
 import (
 	"strings"

cmd/main.go

@@ -16,22 +16,24 @@ import (
 	"sync"
 
 	"github.com/knights-analytics/hugot/options"
-	"github.com/knights-analytics/hugot/pipelineBackends"
+	"github.com/knights-analytics/hugot/pipelinebackends"
 
 	"github.com/urfave/cli/v3"
 
 	"github.com/knights-analytics/hugot"
-	"github.com/knights-analytics/hugot/util"
+	"github.com/knights-analytics/hugot/util/fileutil"
 )
 
-var modelPath string
-var onnxFilename string
-var inputPath string
-var outputPath string
-var pipelineType string
-var sharedLibraryPath string
-var batchSize int
-var modelsDir string
+var (
+	modelPath         string
+	onnxFilename      string
+	inputPath         string
+	outputPath        string
+	pipelineType      string
+	sharedLibraryPath string
+	batchSize         int
+	modelsDir         string
+)
 
 var runCommand = &cli.Command{
 	Name:  "run",
@@ -104,22 +106,22 @@ var runCommand = &cli.Command{
 			Value:       "",
 		},
 	},
-	Action: func(ctx context.Context, cmd *cli.Command) error {
+	Action: func(ctx context.Context, _ *cli.Command) error {
 		var opts []options.WithOption
 		if modelsDir == "" {
 			userDir, err := os.UserHomeDir()
 			if err != nil {
 				return err
 			}
-			modelsDir = util.PathJoinSafe(userDir, "hugot", "models")
+			modelsDir = fileutil.PathJoinSafe(userDir, "hugot", "models")
 		}
 
 		if sharedLibraryPath != "" {
 			opts = append(opts, options.WithOnnxLibraryPath(sharedLibraryPath))
 		} else {
 			homeDir, err := os.UserHomeDir()
 			if err != nil {
-				if exists, err := util.FileExists(path.Join(homeDir, "lib", "hugot", "onnxruntime.so")); err != nil && exists {
+				if exists, err := fileutil.FileExists(path.Join(homeDir, "lib", "hugot", "onnxruntime.so")); err != nil && exists {
 					opts = append(opts, options.WithOnnxLibraryPath(path.Join(homeDir, "lib", "hugot", "onnxruntime.so")))
 				}
 			}
@@ -138,25 +140,25 @@ var runCommand = &cli.Command{
 		}()
 
 		// is the model a full path to a model
-		ok, err := util.FileExists(modelPath)
+		ok, err := fileutil.FileExists(modelPath)
 		if err != nil {
 			return err
 		}
 		if !ok {
 			// is the model the name of a model previously downloaded
-			downloadedModelName := strings.Replace(modelPath, "/", "_", -1)
-			ok, err = util.FileExists(util.PathJoinSafe(modelsDir, downloadedModelName))
+			downloadedModelName := strings.ReplaceAll(modelPath, "/", "_")
+			ok, err = fileutil.FileExists(fileutil.PathJoinSafe(modelsDir, downloadedModelName))
 			if err != nil {
 				return err
 			}
 			if ok {
-				modelPath = util.PathJoinSafe(modelsDir, downloadedModelName)
+				modelPath = fileutil.PathJoinSafe(modelsDir, downloadedModelName)
 			} else {
 				// is the model the name of a model to download
 				if strings.Contains(modelPath, ":") {
 					return fmt.Errorf("filters with : are currently not supported")
 				}
-				err = util.CreateFile(modelsDir, true)
+				err = fileutil.CreateFile(modelsDir, true)
 				if err != nil {
 					return err
 				}
@@ -167,7 +169,7 @@ var runCommand = &cli.Command{
 			}
 		}
 
-		var pipe pipelineBackends.Pipeline
+		var pipe pipelinebackends.Pipeline
 		switch pipelineType {
 		case "tokenClassification":
 			config := hugot.TokenClassificationConfig{
@@ -229,8 +231,8 @@ var runCommand = &cli.Command{
 			var writer io.WriteCloser
 
 			if outputPath != "" {
-				dest := util.PathJoinSafe(outputPath, fmt.Sprintf("result-%d.jsonl", i))
-				writer, err = util.NewFileWriter(dest, "application/json")
+				dest := fileutil.PathJoinSafe(outputPath, fmt.Sprintf("result-%d.jsonl", i))
+				writer, err = fileutil.NewFileWriter(dest, "application/json")
 				if err != nil {
 					return err
 				}
@@ -259,7 +261,7 @@ var runCommand = &cli.Command{
 
 		// read inputs
 
-		exists, err := util.FileExists(inputPath)
+		exists, err := fileutil.FileExists(inputPath)
 		if err != nil {
 			return err
 		}
@@ -277,7 +279,7 @@ var runCommand = &cli.Command{
 				return true, nil
 			}
 
-			err := util.WalkDir()(ctx, inputPath, fileWalker)
+			err := fileutil.WalkDir()(ctx, inputPath, fileWalker)
 			if err != nil {
 				return err
 			}
@@ -345,7 +347,7 @@ func writeOutputs(wg *sync.WaitGroup, processedChannel chan []byte, errorChannel
 	wg.Done()
 }
 
-func processWithPipeline(wg *sync.WaitGroup, inputChannel chan []input, processedChannel chan []byte, errorsChannel chan error, p pipelineBackends.Pipeline) {
+func processWithPipeline(wg *sync.WaitGroup, inputChannel chan []input, processedChannel chan []byte, errorsChannel chan error, p pipelinebackends.Pipeline) {
 	for inputBatch := range inputChannel {
 		inputStrings := make([]string, len(inputBatch))
 		for i := 0; i < len(inputBatch); i++ {

cmd/main_test.go

@@ -12,7 +12,7 @@ import (
 
 	"github.com/urfave/cli/v3"
 
-	"github.com/knights-analytics/hugot/util"
+	"github.com/knights-analytics/hugot/util/fileutil"
 )
 
 //go:embed testData/textClassification.jsonl
@@ -147,7 +147,7 @@ func TestModelChain(t *testing.T) {
 	// wipe the hugo folder
 	userFolder, err := os.UserHomeDir()
 	check(t, err)
-	check(t, util.DeleteFile(util.PathJoinSafe(userFolder, "hugot")))
+	check(t, fileutil.DeleteFile(fileutil.PathJoinSafe(userFolder, "hugot")))
 
 	// try to download the model to hugo folder and run it
 	args := append(baseArgs, "run",