fix all golangci-lint warnings

Author: RJKeevil

.github/workflows/build-test-models.yaml

@@ -28,15 +28,15 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: '1.25.4'
+          go-version: '1.25.5'
       - name: Checkout code
         uses: actions/checkout@v4
       - name: Install dependencies
         run: |
           go mod download
       - name: download models
         run: |
-          go run testData/downloadModels.go
+          go run testcases/downloadModels.go
       - name: List models directory
         run: ls -l ./models
       - name: Remove models from .dockerignore # make sure models folder is not ignored

.github/workflows/release.yaml

@@ -26,7 +26,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: '1.25.4'
+          go-version: '1.25.5'
       - name: Checkout code
         uses: actions/checkout@v4
       - name: Install dependencies

.github/workflows/test.yaml

@@ -16,7 +16,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: '1.25.4'
+          go-version: '1.25.5'
       - name: Checkout code
         uses: actions/checkout@v4
       - name: Install dependencies

.golangci.yml

@@ -1,133 +1,62 @@
+version: "2"
 linters:
+  default: none
   enable:
-    # Check for pass []any as any in variadic func(...any).
-    # Rare case but saved me from debugging a few times.
     - asasalint
-
-    # I prefer plane ASCII identifiers.
-    # Symbol `∆` instead of `delta` looks cool but no thanks.
     - asciicheck
-
-    # Checks for dangerous unicode character sequences.
-    # Super rare but why not to be a bit paranoid?
     - bidichk
-
-    # Checks whether HTTP response body is closed successfully.
     - bodyclose
-
-    # Check whether the function uses a non-inherited context.
     - contextcheck
-
-    # Check for two durations multiplied together.
     - durationcheck
-
-    # Forces to not skip error check.
     - errcheck
-
-    # Checks `Err-` prefix for var and `-Error` suffix for error type.
     - errname
-
-    # Suggests to use `%w` for error-wrapping.
     - errorlint
-
-    # Checks for pointers to enclosing loop variables.
-    - exportloopref
-
-    # Forces to put `.` at the end of the comment. Code is poetry.
     - godot
-
-    # Might not be that important but I prefer to keep all of them.
-    # `gofumpt` is amazing, kudos to Daniel Marti https://github.com/mvdan/gofumpt
-    - gofmt
-    - gofumpt
-    - goimports
-
-    # Allow or ban replace directives in go.mod
-    # or force explanation for retract directives.
-    - gomoddirectives
-
-    # Powerful security-oriented linter. But requires some time to
-    # configure it properly, see https://github.com/securego/gosec#available-rules
     - gosec
-
-    # Linter that specializes in simplifying code.
-    - gosimple
-
-    # Official Go tool. Must have. 
     - govet
-
-    # Detects when assignments to existing variables are not used
-    # Last week I caught a bug with it.
     - ineffassign
-
-    # Fix all the misspells, amazing thing.
     - misspell
-
-    # Finds naked/bare returns and requires change them.
     - nakedret
-
-    # Both require a bit more explicit returns.
     - nilerr
     - nilnil
-
-    # Finds sending HTTP request without context.Context.
     - noctx
-
-    # Forces comment why another check is disabled.
-    # Better not to have //nolint: at all ;)
     - nolintlint
-
-    # Finds slices that could potentially be pre-allocated.
-    # Small performance win + cleaner code.
-    - prealloc
-
-    # Finds shadowing of Go's predeclared identifiers.
-    # I hear a lot of complaints from junior developers.
-    # But after some time they find it very useful.
     - predeclared
-
-    # Lint your Prometheus metrics name.
     - promlinter
-
-    # Checks that package variables are not reassigned.
-    # Super rare case but can catch bad things (like `io.EOF = nil`)
     - reassign
-
-    # Drop-in replacement of `golint`.
     - revive
-
-    # Somewhat similar to `bodyclose` but for `database/sql` package.
     - rowserrcheck
     - sqlclosecheck
-
-    # I have found that it's not the same as staticcheck binary :\
     - staticcheck
-
-    # Is a replacement for `golint`, similar to `revive`.
-    - stylecheck
-
-    # Check struct tags.
-    - tagliatelle
-
-    # Test-related checks. All of them are good.
-    - tenv
     - testableexamples
     - thelper
     - tparallel
-
-    # Remove unnecessary type conversions, make code cleaner
     - unconvert
-
-    # Might be noisy but better to know what is unused
     - unparam
-
-    # Must have. Finds unused declarations.
     - unused
-
-    # Detect the possibility to use variables/constants from stdlib.
     - usestdlibvars
-
-    # Finds wasted assignment statements.
     - wastedassign
-
-version: "2"
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+  settings:
+    nolintlint:
+      allow-unused: false
+      allow-no-explanation: []
+      require-explanation: true
+      require-specific: true
+formatters:
+  enable:
+    - gofmt
+    - gofumpt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

CHANGELOG.md

@@ -23,7 +23,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Changed
 
 - Update to new goMLX project structure (0.24.0+)
-- remove the depency on python when installing goMLX libraries
+- remove the dependency on python when installing goMLX libraries
 
 ## [0.5.5] - 2025-09-30
 

Dockerfile

@@ -1,6 +1,6 @@
 #--- dockerfile to test hugot  ---
 
-ARG GO_VERSION=1.25.4
+ARG GO_VERSION=1.25.5
 ARG ONNXRUNTIME_VERSION=1.22.0
 ARG GOPJRT_VERSION=0.9.1
 ARG BUILD_PLATFORM=linux/amd64

README.md

@@ -217,7 +217,7 @@ following models:
 - **Gemma Family**: `onnx-community/gemma-3-1b-it-ONNX`, `onnx-community/gemma-3-270m-it-ONNX`
 - **Phi Family**: `microsoft/Phi-3-mini-4k-instruct-onnx`, `microsoft/Phi-3.5-mini-instruct-onnx`
 
-Generative models typically use external weights, so use the downloadOptions.ExternalDataPath option when downloading the model. See the [example](./testData/downloadModels.go ) here.
+Generative models typically use external weights, so use the downloadOptions.ExternalDataPath option when downloading the model. See the [example](testcases/downloadModels.go ) here.
 
 ### Example Usage
 ````go
@@ -233,7 +233,7 @@ config := TextGenerationConfig{
     ModelPath:    "./models/KnightsAnalytics_Phi-3.5-mini-instruct-onnx",
     Name:         "testPipeline",
     OnnxFilename: "model.onnx",
-    Options: []pipelineBackends.PipelineOption[*pipelines.TextGenerationPipeline]{
+    Options: []backends.PipelineOption[*pipelines.TextGenerationPipeline]{
         pipelines.WithMaxTokens(200),
         pipelines.WithPhiTemplate(),
     },
@@ -316,7 +316,7 @@ We is currently supported only for the **FeatureExtractionPipeline**. This can b
 {"sentence1": "The quick brown fox jumps over the lazy dog", "sentence2": "A quick brown cow jumps over a lazy caterpillar", "score": 0.5}
 ```
 
-See the [example](./testData/semanticSimilarityTest.jsonl) for a sample dataset.
+See the [example](testcases/semanticSimilarityTest.jsonl) for a sample dataset.
 
 The score is assumed to be a float between 0 and 1 that encodes the semantic similarity between the sentences, and by default a cosine similarity loss is used (see [sentence transformers](https://sbert.net/docs/package_reference/sentence_transformer/losses.html#cosinesimilarityloss)). However, you can also specify a different loss function from `goMLX` using the `XLATrainingOptions` field in the `TrainingConfig` struct. See [the training tests](./hugot_training_test.go) for examples on how to train or fine-tune feature extraction pipelines.
 

pipelineBackends/image_models.go backends/image_models.gopipelineBackends/image_models.go renamed to backends/image_models.go

@@ -1,4 +1,4 @@
-package pipelineBackends
+package backends
 
 import (
 	"fmt"