Skip to content

Commit a87cfb4

Browse files
fix: don't use max
1 parent 73ca043 commit a87cfb4

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

utils/vectors.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package util
33
import (
44
"fmt"
55
"math"
6+
67
"golang.org/x/exp/slices" // like in tokenClassification.go
78
)
89

@@ -78,8 +79,11 @@ func Norm(v []float32, p int) float64 {
7879

7980
// Normalize single vector according to: https://pytorch.org/docs/stable/generated/torch.nn.functional.normalize.html
8081
func Normalize(embedding []float32, p int) []float32 {
81-
const eps = 1e-12
82-
normalizeDenominator := float32(max(Norm(embedding, p), eps))
82+
var normalizeDenominator float32 = 1e-12
83+
embeddingNorm := float32(Norm(embedding, p))
84+
if embeddingNorm > normalizeDenominator {
85+
normalizeDenominator = embeddingNorm
86+
}
8387
for i, v := range embedding {
8488
embedding[i] = v / normalizeDenominator
8589
}

0 commit comments

Comments
 (0)