Merge pull request #216 from Auge19/add_eslint

Add eslint and fix some warnings

Author: phillipc

Makefile

@@ -38,6 +38,9 @@ lint:
 tsc:
 	$(NPX) tsc
 
+eslint:
+	$(NPX) eslint .
+	
 dts:
 	$(NPX) tsc --build tsconfig.dts.json
 

eslint.config.js

@@ -0,0 +1,26 @@
+import globals from "globals";
+import pluginJs from "@eslint/js";
+import tseslint from "typescript-eslint";
+
+
+/** @type {import('eslint').Linter.Config[]} */
+export default [
+  pluginJs.configs.recommended,
+  ...tseslint.configs.recommended,
+  { ignores: ['**/*.{js,mjs,cjs}', 'builds/**/*'] },
+  {
+    rules: {
+      "no-empty": "off",
+      "prefer-rest-params" : "off",
+      "prefer-spread": "off",
+      "prefer-const": "off",
+      "no-useless-escape": "off",
+      "no-array-constructor": "off",
+      "@typescript-eslint/no-array-constructor": "off",
+      "@typescript-eslint/no-explicit-any": "off",
+      "@typescript-eslint/no-require-imports": "off",
+      "@typescript-eslint/no-unused-vars" : "off",
+      "@typescript-eslint/no-unsafe-function-type": "off"
+    }
+  }
+];

global.d.ts

@@ -19,22 +19,21 @@ declare global {
     //This namespace merges the jasmine namespace to correct same tsc warnings
     namespace jasmine {      
 
-        function setNodeText(node, text: string): void
-        var Spec: any;
-        function getGlobal(): any;
-        var updateInterval: number
+        function setNodeText(node, text: string): void        
+        function getGlobal(): any        
         function resolve(promise: Promise<boolean>)
         function prepareTestNode() : HTMLElement
-        function nodeText(node)
-        var Clock: Clock
-        function getEnv(): any;
+        function nodeText(node)        
+        function getEnv(): any
 
-        var FakeTimer: any
-        var undefined: undefined
-        var browserSupportsProtoAssignment: any
-        var ieVersion: any
+        const Matchers: Matchers
+        const Spec: any;
+        const FakeTimer: any
+        const undefined: undefined
 
-        var Matchers: Matchers
+        let browserSupportsProtoAssignment: any
+        let ieVersion: any
+        let updateInterval: number        
 
         interface Matchers<T> {
             toContainText(expected: string, ignoreSpaces: boolean): boolean
@@ -61,6 +60,6 @@ declare global {
     }
 
     interface SymbolConstructor {
-        observable?: Symbol;
+        observable?: symbol;
     } 
 }