Prepare v0.2.0 release

Add getscu, update release packaging, and keep the workspace MSRV-clean.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: knopkem

.github/workflows/release.yml

@@ -62,7 +62,7 @@ jobs:
       - name: Strip binaries (Unix)
         if: runner.os != 'Windows' && !matrix.cross
         run: |
-          for bin in dcmdump echoscu storescu storescp findscu img2dcm dcmcjpls dcmdjpls dcmcjp2k dcmdjp2k; do
+          for bin in dcmdump echoscu storescu storescp findscu getscu img2dcm dcmcjpls dcmdjpls dcmcjp2k dcmdjp2k; do
             strip "target/${{ matrix.target }}/release/${bin}" 2>/dev/null || true
           done
 
@@ -72,7 +72,7 @@ jobs:
         run: |
           STAGING="dicom-toolkit-${{ github.ref_name }}-${{ matrix.target }}"
           mkdir -p "${STAGING}"
-          for bin in dcmdump echoscu storescu storescp findscu img2dcm dcmcjpls dcmdjpls dcmcjp2k dcmdjp2k; do
+          for bin in dcmdump echoscu storescu storescp findscu getscu img2dcm dcmcjpls dcmdjpls dcmcjp2k dcmdjp2k; do
             cp "target/${{ matrix.target }}/release/${bin}" "${STAGING}/"
           done
           cp LICENSE-MIT LICENSE-APACHE NOTICE README.md "${STAGING}/"
@@ -86,7 +86,7 @@ jobs:
         run: |
           $staging = "dicom-toolkit-${{ github.ref_name }}-${{ matrix.target }}"
           New-Item -ItemType Directory -Path $staging
-          $bins = @("dcmdump", "echoscu", "storescu", "storescp", "findscu", "img2dcm", "dcmcjpls", "dcmdjpls", "dcmcjp2k", "dcmdjp2k")
+          $bins = @("dcmdump", "echoscu", "storescu", "storescp", "findscu", "getscu", "img2dcm", "dcmcjpls", "dcmdjpls", "dcmcjp2k", "dcmdjp2k")
           foreach ($bin in $bins) {
             Copy-Item "target/${{ matrix.target }}/release/${bin}.exe" $staging
           }
@@ -146,6 +146,7 @@ jobs:
             | `storescu` | DICOM C-STORE SCU (send files) |
             | `storescp` | DICOM C-STORE SCP (receive files) |
             | `findscu` | DICOM C-FIND SCU (query) |
+            | `getscu` | DICOM C-GET SCU (retrieve files) |
             | `img2dcm` | Convert PNG images to DICOM |
             | `dcmcjpls` | Compress DICOM with JPEG-LS |
             | `dcmdjpls` | Decompress JPEG-LS DICOM files |

README.md

@@ -8,7 +8,7 @@ A pure-Rust port of [DCMTK](https://dicom.offis.de/dcmtk.php.en) 3.7.0 — a com
 
 This is an independent project, not affiliated with or endorsed by OFFIS e.V. See [NOTICE](NOTICE) for attribution details.
 
-[![Tests](https://img.shields.io/badge/tests-487%20passing-brightgreen)](#status)
+[![Tests](https://img.shields.io/badge/tests-488%20passing-brightgreen)](#status)
 
 ---
 
@@ -20,8 +20,8 @@ This is an independent project, not affiliated with or endorsed by OFFIS e.V. Se
 | 2 — Data model & I/O | `dicom-toolkit-data` | 153 |
 | 3 — Networking | `dicom-toolkit-net` | 59 |
 | 4 — Imaging & codecs | `dicom-toolkit-image`, `dicom-toolkit-codec`, `dicom-toolkit-jpeg2000` | 44 + 89 + 46 |
-| Tools | `dicom-toolkit-tools` | 9 integration |
-| **Total** | | **481 unit/integration + 6 doctests = 487 passing, 0 failed** |
+| Tools | `dicom-toolkit-tools` | 10 integration |
+| **Total** | | **482 unit/integration + 6 doctests = 488 passing, 0 failed** |
 
 ---
 
@@ -35,7 +35,7 @@ This is an independent project, not affiliated with or endorsed by OFFIS e.V. Se
 | [`dicom-toolkit-net`](crates/dicom-toolkit-net) | `dcmnet`, `dcmtls` | Async DICOM networking: PDU layer, association, C-ECHO/STORE/FIND/GET/MOVE, TLS |
 | [`dicom-toolkit-image`](crates/dicom-toolkit-image) | `dcmimgle`, `dcmimage` | Pixel pipeline, Modality/VOI LUT, window/level, overlays, color models, PNG export |
 | [`dicom-toolkit-codec`](crates/dicom-toolkit-codec) | `dcmjpeg`, `dcmjpls`, `dcmrle`, `dcmjp2k` | JPEG baseline, **pure-Rust JPEG-LS**, **pure-Rust JPEG 2000** (lossless & lossy), RLE PackBits, codec registry |
-| [`dicom-toolkit-tools`](crates/dicom-toolkit-tools) | `dcmdump`, `echoscu`, etc. | CLI utilities: dump, network SCU/SCP, img2dcm, JPEG-LS/JPEG 2000 compress/decompress (see below) |
+| [`dicom-toolkit-tools`](crates/dicom-toolkit-tools) | `dcmdump`, `echoscu`, etc. | CLI utilities: dump, network SCU/SCP including `getscu`, img2dcm, JPEG-LS/JPEG 2000 compress/decompress (see below) |
 | [`dicom-toolkit-jpeg2000`](crates/dicom-toolkit-jpeg2000) | internal/published fork | Pure-Rust JPEG 2000 engine used by `dicom-toolkit-codec`; published fork with native-bit-depth decode plus DICOM-focused encoder |
 
 ---
@@ -329,6 +329,34 @@ findscu -L PATIENT -k "0010,0010=" -k "0008,0020=20240101" localhost 4242
 
 ---
 
+### `getscu` — retrieve with C-GET
+
+```
+getscu [OPTIONS] <HOST> <PORT>
+
+Options:
+  -a, --aetitle <AE>        Calling AE title [default: GETSCU]
+  -c, --called-ae <AE>      Called AE title [default: ANY-SCP]
+  -d, --output-dir <DIR>    Directory for retrieved DICOM files [default: .]
+  -k, --key <TAG=VALUE>     Query key (repeatable)
+  -L, --level <LEVEL>       Query/retrieve level [default: STUDY]
+  -v, --verbose             Verbose output
+```
+
+**Examples**
+
+```bash
+# Retrieve all instances for a study into ./retrieved
+getscu -d retrieved -L STUDY -k "0020,000D=1.2.3.4.5" pacs.example.com 11112
+
+# Retrieve matching series from a local PACS
+getscu -a MY_SCU -c ORTHANC -d out -L SERIES -k "0020,000E=1.2.3.4.5.6" localhost 4242
+```
+
+Retrieved objects are written as DICOM Part 10 files named after their SOP Instance UID.
+
+---
+
 ### `img2dcm` — convert PNG to DICOM
 
 ```
@@ -476,7 +504,7 @@ Ready-to-run scripts live in [`examples/scripts/`](examples/scripts/) and use th
 |--------|---------------------|
 | `01_dump` | All `dcmdump` output modes: plain, `--meta`, `--no-limit`, `--json`, `--xml`, multi-file batch |
 | `02_network` | Start `storescp` → C-ECHO verify with `echoscu` → send all 5 slices with `storescu` → inspect received files |
-| `03_query` | `findscu` command patterns; set `RUN_LIVE=1` / `$env:RUN_LIVE='1'` to query a real PACS |
+| `03_query` | `findscu` and `getscu` command patterns; set `RUN_LIVE=1` / `$env:RUN_LIVE='1'` to query a real PACS |
 | `04_img2dcm` | Generate a PNG with Python stdlib → wrap as Secondary Capture → dump + JSON export |
 | `05_jpegls` | JPEG-LS lossless & near-lossless round-trip, batch compress/decompress, metadata verification |
 | `06_jp2k` | JPEG 2000 lossless round-trip, lossy smoke test, batch compress/decompress, metadata verification |
@@ -524,7 +552,7 @@ pwsh -File examples/scripts/06_jp2k.ps1
 
 The PowerShell scripts also work on macOS and Linux with [PowerShell Core](https://github.com/PowerShell/PowerShell).
 
-> **Note:** `03_query` shows command-line patterns but does not execute live queries by default. The `storescp` binary now uses the `DicomServer` framework. C-FIND, C-GET, and C-MOVE SCP handling is available in-process via the library; see [DicomServer](#dicomserver) below. Set `RUN_LIVE=1` to use an external Orthanc instance with the query scripts.
+> **Note:** `03_query` shows command-line patterns but does not execute live retrievals by default. The `storescp` binary now uses the `DicomServer` framework. C-FIND, C-GET, and C-MOVE SCP handling is available in-process via the library; see [DicomServer](#dicomserver) below. Set `RUN_LIVE=1` to use an external Orthanc instance with the query scripts.
 
 ---
 

crates/dicom-toolkit-jpeg2000/src/j2c/bitplane.rs

@@ -126,7 +126,7 @@ fn decode_inner(
                     true
                 } else {
                     // Only for cleanup pass.
-                    start_coding_pass.is_multiple_of(3)
+                    start_coding_pass % 3 == 0
                 }
             } else {
                 true

crates/dicom-toolkit-jpeg2000/src/j2c/build.rs

@@ -220,14 +220,14 @@ fn build_code_blocks(
             );
 
             let start = storage.layers.len();
-            storage.layers.extend(iter::repeat_n(
-                Layer {
+            storage.layers.extend(
+                iter::repeat(Layer {
                     // This will be updated once we actually read the
                     // layer segments.
                     segments: None,
-                },
-                tile.num_layers as usize,
-            ));
+                })
+                .take(tile.num_layers as usize),
+            );
             let end = storage.layers.len();
 
             storage.code_blocks.push(CodeBlock {

crates/dicom-toolkit-jpeg2000/src/j2c/fdwt.rs

@@ -198,7 +198,7 @@ fn forward_lift_53(data: &mut [f32]) {
 
     // Step 1: Predict (high-pass) — update odd samples
     // d(i) = x(2i+1) - floor((x(2i) + x(2i+2)) / 2)
-    let last_even = if n.is_multiple_of(2) { n - 2 } else { n - 1 };
+    let last_even = if n % 2 == 0 { n - 2 } else { n - 1 };
     for i in (1..n).step_by(2) {
         let left = data[i - 1];
         let right = if i + 1 < n {
@@ -344,7 +344,7 @@ mod tests {
             data[i] -= ((left + right) * 0.25 + 0.5).floor();
         }
         // Undo predict
-        let last_even = if n.is_multiple_of(2) { n - 2 } else { n - 1 };
+        let last_even = if n % 2 == 0 { n - 2 } else { n - 1 };
         for i in (1..n).step_by(2) {
             let left = data[i - 1];
             let right = if i + 1 < n {

crates/dicom-toolkit-jpeg2000/src/j2c/idwt.rs

@@ -111,7 +111,7 @@ pub(crate) fn apply(
 
     // Determine which buffer we should use first, such that the `coefficients`
     // array will always hold the final values.
-    let mut use_scratch = decompositions.len().is_multiple_of(2);
+    let mut use_scratch = decompositions.len() % 2 == 0;
 
     let mut temp_output = filter_2d(
         IDWTInput::from_sub_band(ll_sub_band, storage),
@@ -359,7 +359,7 @@ fn filter_horizontal(coefficients: &mut [f32], rect: IntRect, transform: Wavelet
 /// The `1D_SR` procedure from F.3.6.
 fn filter_row(scanline: &mut [f32], width: usize, x0: usize, transform: WaveletTransform) {
     if width == 1 {
-        if !x0.is_multiple_of(2) {
+        if x0 % 2 != 0 {
             scanline[0] *= 0.5;
         }
 
@@ -575,7 +575,7 @@ fn filter_vertical_impl<S: Simd>(
     let y0 = rect.y0 as usize;
 
     if height == 1 {
-        if !y0.is_multiple_of(2) {
+        if y0 % 2 != 0 {
             let simd_width = width / SIMD_WIDTH * SIMD_WIDTH;
             for base_column in (0..simd_width).step_by(SIMD_WIDTH) {
                 let mut loaded = f32x8::from_slice(simd, &scanline[base_column..][..SIMD_WIDTH]);

crates/dicom-toolkit-jpeg2000/src/j2c/tile.rs

@@ -603,16 +603,12 @@ impl<'a> ResolutionTile<'a> {
         // is divisible, then we can't take the x/y position of the tile
         // as the start of the precinct, but instead have to advance to the
         // next multiple.
-        if !r_x.is_multiple_of(precinct_x_step)
-            && (self.rect.x0 * (1 << nl_minus_r)).is_multiple_of(precinct_x_step)
-        {
+        if r_x % precinct_x_step != 0 && (self.rect.x0 * (1 << nl_minus_r)) % precinct_x_step == 0 {
             r_x = r_x.checked_next_multiple_of(precinct_x_step)?;
         }
 
         // Same as above.
-        if !r_y.is_multiple_of(precinct_y_step)
-            && (self.rect.y0 * (1 << nl_minus_r)).is_multiple_of(precinct_y_step)
-        {
+        if r_y % precinct_y_step != 0 && (self.rect.y0 * (1 << nl_minus_r)) % precinct_y_step == 0 {
             r_y = r_y.checked_next_multiple_of(precinct_y_step)?;
         }
 

crates/dicom-toolkit-jpeg2000/src/reader.rs

@@ -19,7 +19,7 @@ impl<'a> BitReader<'a> {
     pub(crate) fn align(&mut self) {
         let bit_pos = self.bit_pos();
 
-        if !bit_pos.is_multiple_of(8) {
+        if bit_pos % 8 != 0 {
             self.cur_pos += 8 - bit_pos;
         }
     }

crates/dicom-toolkit-net/src/services/get.rs

@@ -52,6 +52,9 @@ pub struct ReceivedInstance {
     pub sop_class_uid: String,
     /// SOP Instance UID of the received instance.
     pub sop_instance_uid: String,
+    /// Transfer Syntax UID negotiated for the C-STORE sub-operation that
+    /// delivered this dataset.
+    pub transfer_syntax_uid: String,
     /// Raw encoded dataset bytes (use `DicomReader::read_dataset` to decode).
     pub dataset: Vec<u8>,
 }
@@ -114,11 +117,16 @@ pub async fn c_get(assoc: &mut Association, req: GetRequest) -> DcmResult<GetRes
                     .trim_end_matches('\0')
                     .to_string();
                 let store_msg_id = rsp_cmd.get_u16(tags::MESSAGE_ID).unwrap_or(1);
+                let transfer_syntax_uid = assoc
+                    .context_by_id(ctx_id)
+                    .map(|pc| pc.transfer_syntax.trim_end_matches('\0').to_string())
+                    .unwrap_or_else(|| TS_EXPLICIT_LE.to_string());
 
                 let data = assoc.recv_dimse_data().await?;
                 instances.push(ReceivedInstance {
                     sop_class_uid: sop_class.clone(),
                     sop_instance_uid: sop_instance.clone(),
+                    transfer_syntax_uid,
                     dataset: data,
                 });
 

crates/dicom-toolkit-net/tests/e2e.rs

@@ -448,6 +448,18 @@ async fn test_get_loopback() {
     assert_eq!(result.instances.len(), 2, "should receive 2 instances");
     assert_eq!(result.instances[0].sop_instance_uid, "1.2.3.101");
     assert_eq!(result.instances[1].sop_instance_uid, "1.2.3.102");
+    assert_eq!(
+        result.instances[0]
+            .transfer_syntax_uid
+            .trim_end_matches('\0'),
+        TS_EXPLICIT_LE
+    );
+    assert_eq!(
+        result.instances[1]
+            .transfer_syntax_uid
+            .trim_end_matches('\0'),
+        TS_EXPLICIT_LE
+    );
 
     let ds0 = decode_dataset(&result.instances[0].dataset);
     let ds1 = decode_dataset(&result.instances[1].dataset);