Merge branch 'notifications-jsyz'

Author: knowsuchagency

cli/src/commands/current-task.ts

@@ -4,7 +4,6 @@ import { CliError, ExitCodes } from '../utils/errors'
 import type { TaskStatus } from '@shared/types'
 
 const STATUS_MAP: Record<string, TaskStatus> = {
-  done: 'DONE',
   review: 'IN_REVIEW',
   cancel: 'CANCELED',
   'in-progress': 'IN_PROGRESS',
@@ -104,7 +103,7 @@ export async function handleCurrentTaskCommand(
   if (!newStatus) {
     throw new CliError(
       'INVALID_ACTION',
-      `Unknown action: ${action}. Valid actions: done, review, cancel, in-progress, pr, linear`,
+      `Unknown action: ${action}. Valid actions: review, cancel, in-progress, pr, linear`,
       ExitCodes.INVALID_ARGS
     )
   }

cli/src/commands/tasks.ts

@@ -4,7 +4,8 @@ import { output } from '../utils/output'
 import { CliError, ExitCodes } from '../utils/errors'
 import type { TaskStatus } from '@shared/types'
 
-const VALID_STATUSES: TaskStatus[] = ['IN_PROGRESS', 'IN_REVIEW', 'DONE', 'CANCELED']
+// DONE is intentionally excluded - tasks complete automatically when PRs merge
+const VALID_STATUSES: TaskStatus[] = ['IN_PROGRESS', 'IN_REVIEW', 'CANCELED']
 
 export async function handleTasksCommand(
   action: string | undefined,

server/routes/tasks.ts

@@ -118,47 +118,8 @@ function initializeWorktreeForVibora(worktreePath: string): void {
   const claudeLocalPath = path.join(worktreePath, 'CLAUDE.local.md')
   const gitignorePath = path.join(worktreePath, '.gitignore')
 
-  const viboraSection = `
-## Vibora Task Management
-
-You are working inside a Vibora task worktree. Use the \`vibora\` CLI to manage this task:
-
-\`\`\`bash
-# View current task info
-vibora current-task
-
-# Associate a PR with this task (enables auto-completion when merged)
-vibora current-task pr https://github.com/owner/repo/pull/123
-
-# Associate a Linear ticket with this task
-vibora current-task linear https://linear.app/team/issue/TEAM-123
-
-# Update task status when work is complete
-vibora current-task review    # Ready for review
-vibora current-task done      # Task complete
-
-# Send a notification to the user
-vibora notify "Title" "Message body"
-\`\`\`
-
-When you create a PR for this work, run \`vibora current-task pr <url>\` to link it.
-The task will automatically complete when the PR is merged.
-
-### Notifications
-
-All \`vibora current-task\` status changes automatically send notifications, so use those for status updates:
-
-\`\`\`bash
-vibora current-task review    # Notifies: "Task Ready for Review"
-vibora current-task done      # Notifies: "Task Completed"
-\`\`\`
-
-For other communications (questions, issues, or anything not a status change), use:
-
-\`\`\`bash
-vibora notify "Title" "Message body"
-\`\`\`
-`
+  const templatePath = path.join(__dirname, '../templates/CLAUDE.local.template.md')
+  const viboraSection = fs.readFileSync(templatePath, 'utf-8')
 
   // Handle CLAUDE.local.md - create or append
   let claudeContent = ''

server/services/task-status.ts

@@ -13,7 +13,7 @@ import { killClaudeInTerminalsForWorktree } from '../terminal/pty-instance'
  * - Database update (status, position, updatedAt)
  * - WebSocket broadcast
  * - Linear ticket sync
- * - Notifications (for IN_REVIEW, DONE)
+ * - Notifications (for IN_REVIEW only)
  * - Kill Claude processes (for DONE, CANCELED)
  */
 export async function updateTaskStatus(
@@ -57,7 +57,7 @@ export async function updateTaskStatus(
       })
     }
 
-    // Send notifications for specific status transitions
+    // Send notification when task moves to review
     if (newStatus === 'IN_REVIEW') {
       sendNotification({
         title: 'Task Ready for Review',
@@ -66,14 +66,6 @@ export async function updateTaskStatus(
         taskTitle: updated.title,
         type: 'task_status_change',
       })
-    } else if (newStatus === 'DONE') {
-      sendNotification({
-        title: 'Task Completed',
-        message: `Task "${updated.title}" marked as done`,
-        taskId: updated.id,
-        taskTitle: updated.title,
-        type: 'task_status_change',
-      })
     }
 
     // Kill Claude processes for terminal statuses

server/templates/CLAUDE.local.template.md

@@ -0,0 +1,38 @@
+
+## Vibora Task Management
+
+You are working inside a Vibora task worktree. Use the `vibora` CLI to manage this task:
+
+```bash
+# View current task info
+vibora current-task
+
+# Associate a PR with this task (enables auto-completion when merged)
+vibora current-task pr https://github.com/owner/repo/pull/123
+
+# Associate a Linear ticket with this task
+vibora current-task linear https://linear.app/team/issue/TEAM-123
+
+# Mark task ready for review (sends notification)
+vibora current-task review
+
+# Send a notification to the user
+vibora notify "Title" "Message body"
+```
+
+When you create a PR for this work, run `vibora current-task pr <url>` to link it.
+The task will automatically complete when the PR is merged (you cannot mark it done manually).
+
+### Notifications
+
+Moving to review automatically sends a notification:
+
+```bash
+vibora current-task review    # Notifies: "Task Ready for Review"
+```
+
+For other communications (questions, issues, or anything not a status change), use:
+
+```bash
+vibora notify "Title" "Message body"
+```