Merge branch 'add-tests-u0bb'

Author: knowsuchagency

.github/workflows/ci.yml

@@ -0,0 +1,51 @@
+name: CI
+
+on:
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  check:
+    name: Lint & Typecheck
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Bun
+        uses: oven-sh/setup-bun@v2
+
+      - name: Setup mise
+        uses: jdx/mise-action@v2
+
+      - name: Install dependencies
+        run: bun install
+
+      - name: Run lint
+        run: mise run lint
+
+      - name: Run typecheck
+        run: mise run typecheck
+
+  test:
+    name: Test
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Bun
+        uses: oven-sh/setup-bun@v2
+
+      - name: Setup mise
+        uses: jdx/mise-action@v2
+
+      - name: Setup uv
+        uses: astral-sh/setup-uv@v4
+
+      - name: Install dependencies
+        run: bun install
+
+      - name: Run tests
+        run: mise run test

.github/workflows/publish.yml

@@ -6,7 +6,52 @@ on:
       - main
 
 jobs:
+  check:
+    name: Lint & Typecheck
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Bun
+        uses: oven-sh/setup-bun@v2
+
+      - name: Setup mise
+        uses: jdx/mise-action@v2
+
+      - name: Install dependencies
+        run: bun install
+
+      - name: Run lint
+        run: mise run lint
+
+      - name: Run typecheck
+        run: mise run typecheck
+
+  test:
+    name: Test
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Bun
+        uses: oven-sh/setup-bun@v2
+
+      - name: Setup mise
+        uses: jdx/mise-action@v2
+
+      - name: Setup uv
+        uses: astral-sh/setup-uv@v4
+
+      - name: Install dependencies
+        run: bun install
+
+      - name: Run tests
+        run: mise run test
+
   publish:
+    needs: [check, test]
     runs-on: ubuntu-latest
     environment: npm-publish
     permissions:

mise.toml

@@ -121,6 +121,14 @@ fi
 NODE_ENV=production HOST="$HOST" bun server/index.ts
 """
 
+[tasks.test]
+description = "Run all tests"
+run = "bun test"
+
+[tasks."test:watch"]
+description = "Run tests in watch mode"
+run = "bun test --watch"
+
 [tasks.lint]
 description = "Run ESLint"
 run = "bunx eslint ."

server/__tests__/fixtures/app.ts

@@ -0,0 +1,92 @@
+import { createApp } from '../../app'
+
+/**
+ * Test client for making requests to the Hono app.
+ */
+export interface TestAppClient {
+  /** The Hono app instance */
+  app: ReturnType<typeof createApp>
+
+  /** Make a GET request */
+  get: (path: string, headers?: Record<string, string>) => Promise<Response>
+
+  /** Make a POST request with JSON body */
+  post: (path: string, body?: unknown, headers?: Record<string, string>) => Promise<Response>
+
+  /** Make a PATCH request with JSON body */
+  patch: (path: string, body?: unknown, headers?: Record<string, string>) => Promise<Response>
+
+  /** Make a PUT request with JSON body */
+  put: (path: string, body?: unknown, headers?: Record<string, string>) => Promise<Response>
+
+  /** Make a DELETE request */
+  delete: (path: string, headers?: Record<string, string>) => Promise<Response>
+
+  /** Make a request with full control */
+  request: (path: string, init?: RequestInit) => Promise<Response>
+}
+
+/**
+ * Creates a test client for the Hono app.
+ * Uses Hono's native request method for testing without a real server.
+ */
+export function createTestApp(): TestAppClient {
+  const app = createApp()
+
+  const request = async (path: string, init?: RequestInit): Promise<Response> => {
+    const url = `http://localhost${path}`
+    return app.request(url, init)
+  }
+
+  return {
+    app,
+    request,
+
+    get: (path: string, headers?: Record<string, string>) => {
+      return request(path, {
+        method: 'GET',
+        headers,
+      })
+    },
+
+    post: (path: string, body?: unknown, headers?: Record<string, string>) => {
+      return request(path, {
+        method: 'POST',
+        headers: {
+          'Content-Type': 'application/json',
+          ...headers,
+        },
+        body: body !== undefined ? JSON.stringify(body) : undefined,
+      })
+    },
+
+    patch: (path: string, body?: unknown, headers?: Record<string, string>) => {
+      return request(path, {
+        method: 'PATCH',
+        headers: {
+          'Content-Type': 'application/json',
+          ...headers,
+        },
+        body: body !== undefined ? JSON.stringify(body) : undefined,
+      })
+    },
+
+    put: (path: string, body?: unknown, headers?: Record<string, string>) => {
+      return request(path, {
+        method: 'PUT',
+        headers: {
+          'Content-Type': 'application/json',
+          ...headers,
+        },
+        body: body !== undefined ? JSON.stringify(body) : undefined,
+      })
+    },
+
+    delete: (path: string, headers?: Record<string, string>) => {
+      return request(path, {
+        method: 'DELETE',
+        headers,
+      })
+    },
+  }
+}

server/__tests__/fixtures/db.ts

@@ -0,0 +1,102 @@
+import { db, resetDatabase } from '../../db'
+import {
+  tasks,
+  terminals,
+  terminalTabs,
+  terminalViewState,
+  repositories,
+  systemMetrics,
+} from '../../db/schema'
+
+/**
+ * Clears all data from all tables.
+ * Call this in afterEach() to ensure test isolation.
+ */
+export async function clearDatabase(): Promise<void> {
+  // Delete in order to avoid foreign key issues (though SQLite doesn't enforce them by default)
+  await db.delete(systemMetrics)
+  await db.delete(terminals)
+  await db.delete(terminalTabs)
+  await db.delete(terminalViewState)
+  await db.delete(tasks)
+  await db.delete(repositories)
+}
+
+/**
+ * Pushes the schema to the database.
+ * For tests, we use drizzle-kit push equivalent.
+ * Since we're using VIBORA_DIR isolation, the database will be fresh.
+ */
+export async function pushSchema(): Promise<void> {
+  // The database is lazily initialized when first accessed via the db proxy.
+  // drizzle-kit push is typically run separately, but for tests we rely on
+  // the schema being defined. In bundled mode migrations are run, but in tests
+  // we need to create tables manually.
+
+  // Access db to trigger lazy initialization which creates the vibora directory
+  // and database file. Tables are created by drizzle-kit push in dev mode.
+
+  // For tests, we'll run drizzle-kit push via CLI or ensure tables exist.
+  // Since we want no mocks and real behavior, we use the actual drizzle-kit.
+}
+
+/**
+ * Helper to insert a test task.
+ */
+export async function insertTestTask(data: {
+  id?: string
+  title: string
+  repoPath: string
+  repoName?: string
+  baseBranch?: string
+  status?: string
+  position?: number
+}): Promise<typeof tasks.$inferSelect> {
+  const now = new Date().toISOString()
+  const id = data.id ?? crypto.randomUUID()
+
+  const [task] = await db
+    .insert(tasks)
+    .values({
+      id,
+      title: data.title,
+      status: data.status ?? 'IN_PROGRESS',
+      position: data.position ?? 0,
+      repoPath: data.repoPath,
+      repoName: data.repoName ?? 'test-repo',
+      baseBranch: data.baseBranch ?? 'main',
+      createdAt: now,
+      updatedAt: now,
+    })
+    .returning()
+
+  return task
+}
+
+/**
+ * Helper to insert a test repository.
+ */
+export async function insertTestRepository(data: {
+  id?: string
+  path: string
+  displayName?: string
+}): Promise<typeof repositories.$inferSelect> {
+  const now = new Date().toISOString()
+  const id = data.id ?? crypto.randomUUID()
+
+  const [repo] = await db
+    .insert(repositories)
+    .values({
+      id,
+      path: data.path,
+      displayName: data.displayName ?? 'Test Repo',
+      createdAt: now,
+      updatedAt: now,
+    })
+    .returning()
+
+  return repo
+}
+
+// Re-export for convenience
+export { db, resetDatabase }