Fix terminal persistence bug on server restart

Two bugs caused terminals to be incorrectly marked as "exited" on restart
while their dtach sessions were still running:

1. CLI spawned server without VIBORA_DIR, so it inherited CWD and could
   resolve wrong .vibora directory if run from a folder with one

2. Race condition in onExit handler during graceful shutdown - when
   detach() killed the PTY, the handler could mark terminals as exited

Also fix unused cache variables in monitoring.ts - the cache was being
written but never read.

Author: knowsuchagency

cli/src/commands/up.ts

@@ -6,6 +6,7 @@ import { output } from '../utils/output'
 import { CliError, ExitCodes } from '../utils/errors'
 import { writePid, readPid, removePid, isProcessRunning, getPort } from '../utils/process'
 import { confirm } from '../utils/prompt'
+import { getViboraDir } from '../utils/server'
 import {
   isDtachInstalled,
   isBunInstalled,
@@ -134,6 +135,9 @@ export async function handleUpCommand(flags: Record<string, string>) {
   const ptyLibPath = join(packageRoot, 'lib', ptyLibName)
 
   // Start the bundled server
+  // Explicitly set VIBORA_DIR to ensure consistent path resolution
+  // regardless of where the CLI was invoked from
+  const viboraDir = getViboraDir()
   console.error('Starting Vibora server...')
   const serverProc = spawn('bun', [serverPath], {
     detached: true,
@@ -142,6 +146,7 @@ export async function handleUpCommand(flags: Record<string, string>) {
       ...process.env,
       NODE_ENV: 'production',
       PORT: port.toString(),
+      VIBORA_DIR: viboraDir,
       VIBORA_PACKAGE_ROOT: packageRoot,
       BUN_PTY_LIB: ptyLibPath,
     },

package.json

@@ -1,7 +1,7 @@
 {
   "name": "vibora",
   "private": true,
-  "version": "1.12.2",
+  "version": "1.12.3",
   "description": "The Vibe Engineer's Cockpit",
   "license": "PolyForm-Shield-1.0.0",
   "type": "module",

server/routes/monitoring.ts

@@ -908,6 +908,11 @@ async function fetchClaudeUsage(token: string): Promise<ClaudeUsageResponse> {
 monitoringRoutes.get('/claude-usage', async (c) => {
   const now = Date.now()
 
+  // Return cached result if still fresh
+  if (cachedUsage && now - usageCacheTimestamp < USAGE_CACHE_MS) {
+    return c.json(cachedUsage)
+  }
+
   // Check if z.ai is enabled
   const zaiSettings = getZAiSettings()
 

server/terminal/terminal-session.ts

@@ -66,6 +66,10 @@ export class TerminalSession {
   private onData: (data: string) => void
   private onExit: (exitCode: number) => void
 
+  // Flag to indicate we're intentionally detaching (not exiting)
+  // Prevents race condition where onExit marks terminal as exited during graceful detach
+  private isDetaching = false
+
   // Tab association
   private _tabId?: string
   private _positionInTab: number
@@ -191,6 +195,12 @@ export class TerminalSession {
 
     this.pty.onExit(({ exitCode }) => {
       this.pty = null
+
+      // If we're intentionally detaching, don't mark as exited
+      if (this.isDetaching) {
+        return
+      }
+
       const dtach = getDtachService()
 
       if (!dtach.hasSession(this.id)) {
@@ -209,8 +219,12 @@ export class TerminalSession {
     this.buffer.saveToDisk()
 
     if (this.pty) {
+      // Set flag BEFORE killing to prevent onExit from marking as exited
+      this.isDetaching = true
       this.pty.kill()
       this.pty = null
+      // Reset flag after kill completes
+      this.isDetaching = false
     }
   }