Skip to content

Commit b5fa8ba

Browse files
Fix onAttached callback signature mismatch
The AttachXtermOptions interface in use-terminal-store.ts defined onAttached without parameters, but root-store.ts was calling it with terminalId. This caused TypeScript build failures.
1 parent f794f1d commit b5fa8ba

6 files changed

Lines changed: 8 additions & 7 deletions

File tree

.claude-plugin/marketplace.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"name": "vibora",
99
"source": "./plugins/vibora",
1010
"description": "Task orchestration for Claude Code",
11-
"version": "2.12.0"
11+
"version": "2.12.1"
1212
}
1313
]
1414
}

desktop/neutralino.config.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"$schema": "https://raw.githubusercontent.com/neutralinojs/neutralinojs/main/schemas/neutralino.config.schema.json",
33
"applicationId": "io.vibora.desktop",
4-
"version": "2.12.0",
4+
"version": "2.12.1",
55
"defaultMode": "window",
66
"port": 0,
77
"documentRoot": "/resources/",
@@ -26,7 +26,7 @@
2626
],
2727
"globalVariables": {
2828
"APP_NAME": "Vibora",
29-
"APP_VERSION": "2.12.0"
29+
"APP_VERSION": "2.12.1"
3030
},
3131
"modes": {
3232
"window": {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "vibora",
33
"private": true,
4-
"version": "2.12.0",
4+
"version": "2.12.1",
55
"description": "The Vibe Engineer's Cockpit",
66
"license": "PolyForm-Shield-1.0.0",
77
"type": "module",

plugins/vibora/.claude-plugin/plugin.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "vibora",
33
"description": "Vibora task orchestration for Claude Code",
4-
"version": "2.12.0",
4+
"version": "2.12.1",
55
"author": {
66
"name": "Vibora"
77
},

src/stores/hooks/use-terminal-store.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ import { log } from '@/lib/logger'
99
* Options for attaching an xterm.js instance
1010
*/
1111
interface AttachXtermOptions {
12-
onAttached?: () => void
12+
/** Called when terminal is attached. Receives the actual terminal ID (may differ from tempId after optimistic update). */
13+
onAttached?: (terminalId: string) => void
1314
}
1415

1516
/**

src/stores/root-store.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ export const RootStore = types
171171
/** Pending optimistic updates awaiting server confirmation, keyed by requestId */
172172
pendingUpdates: new Map<string, PendingUpdate>(),
173173
/** Callbacks to invoke when terminal:attached is received */
174-
onAttachedCallbacks: new Map<string, () => void>(),
174+
onAttachedCallbacks: new Map<string, (terminalId: string) => void>(),
175175
/** Terminals that received terminal:attached before callback was registered */
176176
terminalsReadyForCallback: new Set<string>(),
177177
/** Last focused terminal ID (for reconnection focus restoration) */

0 commit comments

Comments
 (0)