Problem with configuration generic client

[bas4555]

Problem with configuration generic ouath2-client: https://github.com/ekapusta/oauth2-esia

This client requires data (signer) in collaborators array in Provider construct

public function __construct(array $options = [], array $collaborators = [])
    {
        parent::__construct($options, $collaborators);
        if (!filter_var($this->remoteUrl, FILTER_VALIDATE_URL)) {
            throw new InvalidArgumentException('Remote URL is not provided!');
        }
        if (!file_exists($this->remoteCertificatePath)) {
            throw new InvalidArgumentException('Remote certificate is not provided!');
        }

        if (isset($collaborators['signer']) && $collaborators['signer'] instanceof SignerInterface) {
            $this->signer = $collaborators['signer'];
            $this->encoder = new Encoder();
        } else {
            throw new InvalidArgumentException('Signer is not provided!');
        }
    }

But through parameters in the yaml file, I can pass only the provider_options array. Is it possible to pass collaborators array with signer?

[weaverryan]

Hi there!

I don't think this is currently possible - sorry. But, it could be easily added - we DO manage this collaborators array, we just need to add a signer to it. Probably we would need to:

1. Add a new option for each client - I think here:

   oauth2-client-bundle/src/DependencyInjection/KnpUOAuth2ClientExtension.php

   Lines 332 to 349 in f6743e2

   	private function buildConfigurationForType(NodeDefinition $node, $type)
   	{
   	$optionsNode = $node->children();
   	$optionsNode
   	->scalarNode('client_id')->isRequired()->end()
   	->scalarNode('client_secret')->isRequired()->end()
   	->scalarNode('redirect_route')->isRequired()->end()
   	->arrayNode('redirect_params')
   	->prototype('scalar')->end()
   	->end()
   	->booleanNode('use_state')->defaultValue(true)->end()
   	;
   	// allow the specific provider to add more options
   	$this->getConfigurator($type)
   	->buildConfiguration($optionsNode);
   	$optionsNode->end();
   	}

2. Then check for that key and use it around here:

   oauth2-client-bundle/src/DependencyInjection/KnpUOAuth2ClientExtension.php

   Line 199 in f6743e2

   $collaborators = [];

A PR would be warmly welcomed!

Cheers!