diff --git a/Korpora/utils.py b/Korpora/utils.py index 933e4aa..e28fc0d 100644 --- a/Korpora/utils.py +++ b/Korpora/utils.py @@ -157,7 +157,26 @@ def web_download_untar(url, tar_path, corpus_name='', force_download=False): return None data_root = os.path.dirname(tar_path) with tarfile.open(tar_path) as tar: - tar.extractall(data_root) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, data_root) print(f'decompress {tar_path}')