Record the command's id in CFSetExitCode for built-in handlers

handleCommand receives the whole T_SimpleCommand as `cmd`, and the ordinary
path registers the exit code against it through
`handleOthers (getId cmd) ...`. regularExpansionWithStatus, used by the
built-in table, shadowed that name with the command's first word, so printf,
unset, wait, mapfile, readarray, read and the four DEFINE_* commands recorded
their exit code under the id of a T_NormalWord instead.

Consumers that resolve the id through idMap then get a word where they expect
a command. checkOverwrittenExitCode is one of them: getCommandBasename is
Nothing for a T_NormalWord, so isPrinting never matched and SC2320 stayed
silent for printf while firing for echo, which is not in the table and goes
through handleOthers.

Drop the shadowing pattern so cmd again refers to the command.

Fixes #3490

Author: Eljees

src/ShellCheck/Analytics.hs

@@ -5097,6 +5097,8 @@ prop_checkOverwrittenExitCode5 = verify checkOverwrittenExitCode "x; if [ $? -eq
 prop_checkOverwrittenExitCode6 = verify checkOverwrittenExitCode "x; [ $? -gt 0 ] && fail=$?"
 prop_checkOverwrittenExitCode7 = verifyNot checkOverwrittenExitCode "[ 1 -eq 2 ]; status=$?"
 prop_checkOverwrittenExitCode8 = verifyNot checkOverwrittenExitCode "[ 1 -eq 2 ]; exit $?"
+prop_checkOverwrittenExitCode9 = verify checkOverwrittenExitCode "x; printf '%d' $?; [ $? -eq 0 ]"
+prop_checkOverwrittenExitCode10 = verifyNot checkOverwrittenExitCode "read -r x; [ $? -eq 0 ]"
 checkOverwrittenExitCode params t =
     case t of
         T_DollarBraced id _ val | getLiteralString val == Just "?" -> check id

src/ShellCheck/CFG.hs

@@ -1196,7 +1196,7 @@ handleCommand cmd vars args literalCmd = do
 
             linkRanges $ [args] ++ assignments ++ [exe] ++ dropAssignments
 
-    regularExpansionWithStatus vars args@(cmd NE.:| _) p = do
+    regularExpansionWithStatus vars args p = do
         initial <- regularExpansion vars (NE.toList args) p
         status <- newNodeRange $ CFSetExitCode (getId cmd)
         linkRange initial status