`get_disaggregated_stats()` returns wrong counts

As discovered by @noliveleger, `counter['__submissions__']` contains the count of all submissions, including those where no response was provided. This leads to `total_count` exceeding the total number of submissions.
https://github.com/kobotoolbox/formpack/blob/0a11feeced50914c0584e3972346ed94c3ab223c/src/formpack/schema/fields.py#L221-L231

	def get_disaggregated_stats(self, metrics, top_splitters,
	lang=UNSPECIFIED_TRANSLATION, limit=100):

	not_provided = 0
	provided = 0
	for val, counter in metrics.items():
	not_provided += counter.pop(None, 0)
	provided += counter.pop('__submissions__', 0)

	return {
	'total_count': not_provided + provided,

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`get_disaggregated_stats()` returns wrong counts #190

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

get_disaggregated_stats() returns wrong counts #190

Description