Date shifts to previous day in single submission view modal when browser timezone behind UTC

[esario]

Description

When you have a date question in a form and view a submission in KPI, the date shifts one day back on a computer that is behind UTC timezone.

Steps to reproduce

1. Switch your computer timezone to e.g. UTC -5
2. Deploy the following XLSForm and submit the form once. Use today's date in the date picker.

type	name	label	required	calculation
start	start
end	end
date	activity_date	Date of the activity	TRUE

3. Navigate to table view and note that the date captured shows today's date

4. Click the view icon to open the single submission view modal and note that the date has shifted back by one day.

5. (Click view to open in Enketo and note that the date is today's date)

Expected behaviour

Submission view modal shows the actual date.

Actual behaviour

Submission view modal shows the date as the actual day minus one day.

Additional context

This issue has existed at least since 2022. See the following threads on the Community:

• https://community.kobotoolbox.org/t/inconsistencies-in-dates-when-viewing-data/35693
• https://community.kobotoolbox.org/t/error-in-date-seen-in-view-utility/45127

Related to #3943?

[esario]

Workaround

Create a simple calculate question to store the date value:

type	name	label	required	calculation
start	start
end	end
date	activity_date	Date of the activity	TRUE
calculate	activity_date_fix	Correct date of the activity		${activity_date}

[magicznyleszek]

Little digging:

• Data Table (in table.tsx file) uses formatTimeDateShort function for start, end, and _submission_time, for any other (so date, datetime, and time questions) we display raw value from API response
• Single Submission Modal (in submissionDataTable.tsx file) uses formatDate function for date questions and formatTimeDate function for datetime questions, for time questions it displays raw value

[tiritea]

Data Table (in table.tsx file) uses formatTimeDateShort function for start, end, and _submission_time, for any other (so date, datetime, and time questions) we display raw value from API response

start, end and _submission_time are ostensibly meta data (about the submission itself, not the data being collected), so it seems somewhat appropriate to me to display these in the context of the observer; ie translated to local time. Whereas

for any other (so date, datetime, and time questions) we display raw value from API response

These are 'raw data' and, depending on the client, could include an arbitrary time offset (see https://getodk.github.io/xforms-spec/#data-type:dateTime). So, similarly, it seems to me most appropriate to display this as raw data, and not translated to local time. (note: date and time wont have any timezone info; only dateTime)

That is, IMO, the data table seems to be doing it right, but Single Submission Modal is not. I note, above, there was no guidance as which way to go.... :-). But as with anything to do with dates, there's always probably some room for discussion; attn @jnm