fix(ux): Fix SMB/USB destination picker, path checks, and logs folder (v1.7.3)

Three bugs reported in issue #2 (JimmysDev):

- browseForDestination: set panel.prompt="Select" and add message hint.
  On macOS 15, clicking "Open" on a directory in NSOpenPanel navigates
  into it rather than selecting it, making external volumes impossible
  to set as a destination without knowing this quirk.

- performConnectionTest: use isReadableFile for /Volumes/ source paths;
  destination check now passes when path doesn't exist (rsync creates it)
  and only fails if the volume root itself is not mounted.

- openLogsFolder: create ~/Library/Application Support/RsyncGUI/Logs/
  before opening it. NSWorkspace.open silently does nothing on a
  nonexistent URL, making the button appear broken.

Bumps version to 1.7.3 (build 18).

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Author: kochj23

README.md

@@ -1,4 +1,4 @@
-# RsyncGUI v1.7.2
+# RsyncGUI v1.7.3
 
 ![Build](https://github.com/kochj23/RsyncGUI/actions/workflows/build.yml/badge.svg)
 
@@ -20,7 +20,7 @@ A modern, open-source alternative to the discontinued [RsyncOSX](https://github.
 
 ## Download
 
-Download the latest release: [RsyncGUI v1.7.2](https://github.com/kochj23/RsyncGUI/releases/latest)
+Download the latest release: [RsyncGUI v1.7.3](https://github.com/kochj23/RsyncGUI/releases/latest)
 
 Or build from source (see below).
 
@@ -37,7 +37,23 @@ If you're coming from RsyncOSX (discontinued), RsyncGUI offers:
 
 ---
 
-## 🆕 What's New in v1.7.2 (March 2026)
+## 🆕 What's New in v1.7.3 (March 2026)
+
+### Bug Fix Release — SMB/USB Destination, Path Checks, Logs
+
+**SMB share → USB drive destination picker — fixed:**
+- The folder browser now shows a "Select" button instead of "Open" and displays a hint message. On macOS 15, clicking "Open" on a directory navigated *into* it rather than selecting it, making it impossible to set an SMB or USB destination without knowing to navigate inside the target folder first.
+
+**"Some checks failed" on valid external/network paths — fixed:**
+- Source path check now uses `isReadableFile` for `/Volumes/` paths. `fileExists` can return `false` on SMB shares and USB drives even when mounted and accessible, causing a false failure.
+- Destination path check no longer fails when the path doesn't exist. rsync creates destination directories — a missing path is expected on first run. The check now only fails if the volume itself is not mounted.
+
+**"Open Logs Folder" button does nothing — fixed:**
+- `~/Library/Application Support/RsyncGUI/Logs/` is now created if it doesn't exist before trying to open it. `NSWorkspace.open()` silently does nothing on a nonexistent URL.
+
+---
+
+## What's New in v1.7.2 (March 2026)
 
 ### Bug Fix Release — Large Jobs, iCloud, and Reliability
 

RsyncGUI.xcodeproj/project.pbxproj

@@ -599,7 +599,7 @@
 				CODE_SIGN_ENTITLEMENTS = "RsyncGUI Widget/RsyncGUI_Widget.entitlements";
 				CODE_SIGN_IDENTITY = "-";
 				CODE_SIGN_STYLE = Automatic;
-				CURRENT_PROJECT_VERSION = 17;
+				CURRENT_PROJECT_VERSION = 18;
 				DEVELOPMENT_TEAM = "";
 				GENERATE_INFOPLIST_FILE = YES;
 				INFOPLIST_FILE = "RsyncGUI Widget/Info.plist";
@@ -611,7 +611,7 @@
 					"@executable_path/../../../../Frameworks",
 				);
 				MACOSX_DEPLOYMENT_TARGET = 14.0;
-				MARKETING_VERSION = 1.7.2;
+				MARKETING_VERSION = 1.7.3;
 				PRODUCT_BUNDLE_IDENTIFIER = com.jordankoch.rsyncgui.widget;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SDKROOT = macosx;
@@ -629,7 +629,7 @@
 				CODE_SIGN_ENTITLEMENTS = "RsyncGUI Widget/RsyncGUI_Widget.entitlements";
 				CODE_SIGN_IDENTITY = "-";
 				CODE_SIGN_STYLE = Automatic;
-				CURRENT_PROJECT_VERSION = 17;
+				CURRENT_PROJECT_VERSION = 18;
 				DEVELOPMENT_TEAM = "";
 				GENERATE_INFOPLIST_FILE = YES;
 				INFOPLIST_FILE = "RsyncGUI Widget/Info.plist";
@@ -641,7 +641,7 @@
 					"@executable_path/../../../../Frameworks",
 				);
 				MACOSX_DEPLOYMENT_TARGET = 14.0;
-				MARKETING_VERSION = 1.7.2;
+				MARKETING_VERSION = 1.7.3;
 				PRODUCT_BUNDLE_IDENTIFIER = com.jordankoch.rsyncgui.widget;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SDKROOT = macosx;

RsyncGUI/Views/JobEditorView.swift

@@ -521,11 +521,17 @@ struct JobEditorView: View {
         panel.canChooseFiles = false
         panel.canChooseDirectories = true
         panel.allowsMultipleSelection = false
+        // "Select" instead of "Open" avoids the macOS quirk where clicking
+        // "Open" on a directory navigates into it rather than selecting it.
+        // This is especially confusing on SMB shares and USB drives.
+        panel.prompt = "Select"
+        panel.message = "Navigate inside the destination folder, then click Select."
 
         guard panel.runModal() == .OK, let url = panel.url else { return }
+        let selectedPath = url.path
         DispatchQueue.main.async {
             if let index = self.job.destinations.firstIndex(where: { $0.id == destinationId }) {
-                self.job.destinations[index].path = url.path
+                self.job.destinations[index].path = selectedPath
             }
         }
     }
@@ -1334,7 +1340,11 @@ struct JobEditorView: View {
 
         // 1. Check source path
         let sourcePath = job.source.replacingOccurrences(of: "~", with: FileManager.default.homeDirectoryForCurrentUser.path)
-        let sourceExists = FileManager.default.fileExists(atPath: sourcePath)
+        // Use isReadableFile for /Volumes/ paths (SMB/USB) — fileExists can return
+        // false on network/external volumes even when the path is valid and mounted.
+        let sourceExists = sourcePath.hasPrefix("/Volumes/")
+            ? FileManager.default.isReadableFile(atPath: sourcePath)
+            : FileManager.default.fileExists(atPath: sourcePath)
         checks.append(ConnectionCheck(
             name: "Source Path",
             passed: sourceExists,
@@ -1344,11 +1354,28 @@ struct JobEditorView: View {
         // 2. Check destination path (if local)
         if !job.isRemote {
             let destPath = job.destination.replacingOccurrences(of: "~", with: FileManager.default.homeDirectoryForCurrentUser.path)
+            // Destination not existing is not a failure — rsync creates it.
+            // Only fail if the path's parent volume is unreachable.
             let destExists = FileManager.default.fileExists(atPath: destPath)
+            let destReachable: Bool
+            if destExists {
+                destReachable = true
+            } else if destPath.hasPrefix("/Volumes/") {
+                // For external/network volumes, check if the volume root is mounted
+                let components = destPath.split(separator: "/", maxSplits: 3)
+                let volumeRoot = components.count >= 3 ? "/Volumes/\(components[2])" : destPath
+                destReachable = FileManager.default.fileExists(atPath: volumeRoot)
+            } else {
+                destReachable = true // rsync will create local paths
+            }
             checks.append(ConnectionCheck(
                 name: "Destination Path",
-                passed: destExists,
-                message: destExists ? "✅ \(destPath)" : "⚠️  Path not found (will be created): \(destPath)"
+                passed: destReachable,
+                message: destExists
+                    ? "✅ \(destPath)"
+                    : destReachable
+                        ? "⚠️  Path not found (will be created): \(destPath)"
+                        : "❌ Volume not mounted: \(destPath)"
             ))
         }
 

RsyncGUI/Views/SettingsView.swift

@@ -187,6 +187,11 @@ struct AdvancedSettings: View {
             return
         }
         let logsURL = appSupport.appendingPathComponent("RsyncGUI/Logs")
+        // Create the directory if it doesn't exist yet — NSWorkspace.open silently
+        // does nothing on a nonexistent URL, which caused the button to appear broken.
+        if !FileManager.default.fileExists(atPath: logsURL.path) {
+            try? FileManager.default.createDirectory(at: logsURL, withIntermediateDirectories: true)
+        }
         NSWorkspace.shared.open(logsURL)
     }