Enhance location grid meta deletion logic

- Updated the delete_location_grid_meta method to include an optional parameter for location_meta_field_settings, allowing for better handling of shared dt rows.
- Improved the logic to unlink fields and delete metadata only when necessary, enhancing performance and preventing unintended data loss.
- Adjusted calls to delete_location_grid_meta throughout the codebase to accommodate the new parameter, ensuring consistent behavior across the application.

Author: kodinkat

dt-mapping/location-grid-meta.php

@@ -215,8 +215,9 @@ public static function add_location_grid_meta( $post_id, array $location_grid_me
          * @param int         $value
          * @param array|null  $existing_post
          * @param string      $location_meta_field_key DT field key for postmeta pointers (default location_grid_meta).
+         * @param array|null  $location_meta_field_settings Field definitions for the post type; when set, shared dt rows are not removed while another location_meta field still references the grid_meta_id.
          */
-        public static function delete_location_grid_meta( int $post_id, $type, int $value, ?array $existing_post = null, string $location_meta_field_key = 'location_grid_meta' ) {
+        public static function delete_location_grid_meta( int $post_id, $type, int $value, ?array $existing_post = null, string $location_meta_field_key = 'location_grid_meta', ?array $location_meta_field_settings = null ) {
             global $wpdb;
 
             $status = false;
@@ -230,17 +231,31 @@ public static function delete_location_grid_meta( int $post_id, $type, int $valu
 
                 switch ( $type ) {
                     case 'grid_meta_id':
-                        $postmeta_id_location_grid = $wpdb->get_var( $wpdb->prepare( "SELECT postmeta_id_location_grid FROM $wpdb->dt_location_grid_meta WHERE grid_meta_id = %d", $value ) );
+                        $grid_meta_id = (int) $value;
+                        if ( $grid_meta_id < 1 ) {
+                            break;
+                        }
 
-                        delete_metadata_by_mid( 'post', $postmeta_id_location_grid );
-                        $wpdb->delete($wpdb->dt_location_grid_meta, [
-                            'post_id' => $post_id,
-                            'grid_meta_id' => $value
-                        ]);
-                        delete_post_meta( $post_id, 'location_grid_meta', $value );
-                        if ( $location_meta_field_key !== 'location_grid_meta' ) {
-                            delete_post_meta( $post_id, $location_meta_field_key, $value );
+                        // Unlink this field only first; multiple location_meta fields can share one dt row (same lat/lng).
+                        delete_post_meta( $post_id, $location_meta_field_key, $grid_meta_id );
+
+                        if ( is_array( $location_meta_field_settings )
+                            && Disciple_Tools_Posts::post_references_grid_meta_id( $post_id, $grid_meta_id, $location_meta_field_settings ) ) {
+                            $status = true;
+                            break;
                         }
+
+                        $postmeta_id_location_grid = $wpdb->get_var( $wpdb->prepare( "SELECT postmeta_id_location_grid FROM $wpdb->dt_location_grid_meta WHERE grid_meta_id = %d", $grid_meta_id ) );
+
+                        delete_metadata_by_mid( 'post', $postmeta_id_location_grid );
+                        $wpdb->delete(
+                            $wpdb->dt_location_grid_meta,
+                            [
+                                'post_id' => $post_id,
+                                'grid_meta_id' => $grid_meta_id,
+                            ]
+                        );
+                        delete_post_meta( $post_id, 'location_grid_meta', $grid_meta_id );
                         $status = true;
                         break;
 

dt-posts/posts.php

@@ -1870,7 +1870,7 @@ public static function update_multi_select_fields( array $field_settings, int $p
     /**
      * Whether a grid_meta_id is still referenced by any location_meta field postmeta on this post.
      */
-    private static function post_references_grid_meta_id( int $post_id, int $grid_meta_id, array $field_settings ): bool {
+    public static function post_references_grid_meta_id( int $post_id, int $grid_meta_id, array $field_settings ): bool {
         foreach ( $field_settings as $meta_key => $def ) {
             if ( ( $def['type'] ?? '' ) !== 'location_meta' ) {
                 continue;
@@ -1955,7 +1955,7 @@ public static function update_location_grid_fields( array $field_settings, int $
                             continue;
                         }
                         if ( ! self::post_references_grid_meta_id( $post_id, $candidate_id, $field_settings ) ) {
-                            Location_Grid_Meta::delete_location_grid_meta( $post_id, 'grid_meta_id', $candidate_id, $existing_post, $field_key );
+                            Location_Grid_Meta::delete_location_grid_meta( $post_id, 'grid_meta_id', $candidate_id, $existing_post, $field_key, $field_settings );
                         }
                     }
                     $existing_post[ $field_key ] = [];
@@ -1966,7 +1966,7 @@ public static function update_location_grid_fields( array $field_settings, int $
 
                     // delete
                     if ( isset( $value['delete'] ) && $value['delete'] == true ) {
-                        Location_Grid_Meta::delete_location_grid_meta( $post_id, 'grid_meta_id', $value['grid_meta_id'], $existing_post, $field_key );
+                        Location_Grid_Meta::delete_location_grid_meta( $post_id, 'grid_meta_id', $value['grid_meta_id'], $existing_post, $field_key, $field_settings );
                     }
 
                     // Add by pre-defined meta grid values.