Nits

Author: kohler

scripts/script.js

@@ -13407,13 +13407,15 @@ hotcrp.load_paper_sidebar = function () {
 
 hotcrp.replace_editable_field = function (field, elt) {
     var pfe = $$(field).closest(".pfe");
-    if (elt.tagName !== "DIV" || !hasClass(elt, "pfe")) {
-        throw new Error("bad DIV");
+    if ((elt.tagName !== "DIV" && elt.tagName !== "FIELDSET")
+        || !hasClass(elt, "pfe")) {
+        throw new Error("bad replacement");
     }
     pfe.className = elt.className;
     pfe.replaceChildren();
-    while (elt.firstChild)
+    while (elt.firstChild) {
         pfe.appendChild(elt.firstChild);
+    }
     add_pslitem_pfe.call(pfe);
 };
 

src/api/api_manageemail.php

@@ -286,7 +286,7 @@ private function ecrun_transferreview() {
                 $this->inform_at("email", $this->conf->_("<5>Reviews can’t be transferred from {src} to {dst} because there are {submissions} for which both accounts have reviews. (<a href=\"{searchurl}\">List them</a>)",
                     new FmtArg("src", $this->user->email, 0),
                     new FmtArg("dst", $this->dstuser->email, 0),
-                    new FmtArg("searchurl", $this->conf->hoturl("search", ["q" => "pidcode:" . SessionList::encode_ids($bothreviewed)], Conf::HOTURL_RAW))));
+                    new FmtArg("searchurl", $this->conf->hoturl("search", ["q" => "pidcode:" . SessionList::encode_ids($bothreviewed)], Conf::HOTURL_RAW), 0)));
             }
             if (!empty($dstconflict)) {
                 sort($dstconflict);
@@ -297,7 +297,7 @@ private function ecrun_transferreview() {
                 $this->inform_at("email", $this->conf->_("<5>Transferring reviews from {src} to {dst} would override some conflicts. (<a href=\"{searchurl}\">List them</a>)",
                     new FmtArg("src", $this->user->email, 0),
                     new FmtArg("dst", $this->dstuser->email, 0),
-                    new FmtArg("searchurl", $this->conf->hoturl("search", ["q" => "pidcode:" . SessionList::encode_ids($dstconflict)], Conf::HOTURL_RAW))));
+                    new FmtArg("searchurl", $this->conf->hoturl("search", ["q" => "pidcode:" . SessionList::encode_ids($dstconflict)], Conf::HOTURL_RAW), 0)));
             }
             if (!empty($bothreviewed)
                 || (!empty($dstconflict) && !$this->viewer->privChair)) {