Merge pull request #49 from koichiro/feature/fix-cloud-run-env-var-3

Remove the default value of the environment variable

Author: koichiro

cloudbuild.yaml

@@ -38,9 +38,10 @@ options:
 
 substitutions:
   _REGION: "asia-northeast1"
-  _BQ_DATASET_ID: "airbnb_management"
-  _BQ_TABLE_ID: "earnings_cleaned"
+  _BQ_DATASET_ID: "REQUIRED_SET_IN_TRIGGER_UI"
+  _BQ_TABLE_ID: "REQUIRED_SET_IN_TRIGGER_UI"
   _SERVICE_NAME: "airbnb-payouts-importer"
   _TRIGGER_NAME: "airbnb-payouts-importer-trigger"
-  _TRIGGER_BUCKET: "YOUR_GCS_BUCKET_NAME"
-  _SERVICE_ACCOUNT_EMAIL: "YOUR_SERVICE_ACCOUNT_EMAIL"
+  _TRIGGER_BUCKET: "REQUIRED_SET_IN_TRIGGER_UI"
+  _SERVICE_ACCOUNT_EMAIL: "REQUIRED_SET_IN_TRIGGER_UI"
+T_EMAIL: "YOUR_SERVICE_ACCOUNT_EMAIL"

lib/airbnb_payous/processor.rb

@@ -51,15 +51,10 @@ def extract_event_data(event_payload)
 
     def default_gateway
       BigqueryGateway.new(
-        project_id: env_value("GCP_PROJECT_ID"),
-        dataset_id: env_value("BQ_DATASET_ID", "airbnb_management"),
-        table_id: env_value("BQ_TABLE_ID", "earnings_cleaned")
+        project_id: ENV["GCP_PROJECT_ID"],
+        dataset_id: ENV["BQ_DATASET_ID"],
+        table_id: ENV["BQ_TABLE_ID"]
       )
     end
-
-    def env_value(key, default = nil)
-      val = ENV[key]
-      (val.nil? || val.empty?) ? default : val
-    end
   end
 end