darwin: prevent adding menu items after finalization

kojix2 · kojix2 · commit 62b752fd97fc · 2026-05-06T02:35:23.000Z
diff --git a/darwin/menu.m b/darwin/menu.m
@@ -322,6 +322,8 @@ void uiMenuItemSetChecked(uiMenuItem *item, int checked)
 
 void uiMenuAppendSeparator(uiMenu *m)
 {
+	if ([uiprivAppDelegate().menuManager finalized])
+		uiprivUserBug("You can't create a new menu item after menus have been finalized.");
 	[m->menu addItem:[NSMenuItem separatorItem]];
 }
 

Original file line number	Diff line number	Diff line change
`@@ -322,6 +322,8 @@ void uiMenuItemSetChecked(uiMenuItem *item, int checked)`
`322`	`322`
`323`	`323`	`void uiMenuAppendSeparator(uiMenu *m)`
`324`	`324`	`{`
	`325`	`+ if ([uiprivAppDelegate().menuManager finalized])`
	`326`	`+ uiprivUserBug("You can't create a new menu item after menus have been finalized.");`
`325`	`327`	`[m->menu addItem:[NSMenuItem separatorItem]];`
`326`	`328`	`}`
`327`	`329`