From 9716520a74c8f43b07b6161b96f1c8e23d596553 Mon Sep 17 00:00:00 2001 From: Olek Raymond <123381967+OlekRaymond@users.noreply.github.com> Date: Mon, 14 Jul 2025 11:49:32 +0000 Subject: [PATCH 1/2] Makes Windows build fail earlier with more descriptive error message --- .gitignore | 2 ++ CMakeLists.txt | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/.gitignore b/.gitignore index 8c27e3e1b..22eb8433c 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,5 @@ *~ *.so /src/tools/simple-kernel-timer/kp_reader +# Expected build dir +/build diff --git a/CMakeLists.txt b/CMakeLists.txt index bc3b1e63b..018b48018 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -2,6 +2,11 @@ cmake_minimum_required(VERSION 3.16 FATAL_ERROR) project(KokkosTools CXX) +# Users cannot use Kokkos tools on windows, we want to test things on windows/msvc however +if(WIN32 AND NOT DEFINED KOKKOS_TOOLS_TEST_WINDOWS) + message(FATAL_ERROR "Kokkos tools is not supported on Windows, please attempt to profile on expected hardware") +endif() + if(NOT DEFINED CMAKE_CXX_STANDARD) set(CMAKE_CXX_STANDARD 17) endif() From 66e52de192f4ef16481d1b38fe61779ae35e5ae9 Mon Sep 17 00:00:00 2001 From: Olek Raymond <123381967+OlekRaymond@users.noreply.github.com> Date: Mon, 14 Jul 2025 15:17:36 +0000 Subject: [PATCH 2/2] Addresses review comments --- .gitignore | 2 -- 1 file changed, 2 deletions(-) diff --git a/.gitignore b/.gitignore index 22eb8433c..8c27e3e1b 100644 --- a/.gitignore +++ b/.gitignore @@ -1,5 +1,3 @@ *~ *.so /src/tools/simple-kernel-timer/kp_reader -# Expected build dir -/build